Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLSC does not provide correct output for attribute **voPersonPolicyAgreement** #1675

Open
HarryKodden opened this issue Nov 4, 2024 · 1 comment
Assignees

Comments

@HarryKodden
Copy link
Member

HarryKodden commented Nov 4, 2024

When a user has accepted 1 or more AUP's for services, it is expected that there is a voPersonPolicyAgreement for each service.

It is found that the current Test does not process the AUP correctly if a user has accepted more than 1 AUP's.

The error is in this line:

                    for a in person_object[list(person_object)[0]]:
                        if a.startswith('voPersonPolicyAgreement'):
                            policy_agreement_attribute = True
                            break

The logical error here is that from the attributes of the person object, only the first attribute is checked to see if it matches the string 'voPersonPolicyAgreement', off cours that is very unlikely to be the case.
The reason this error has not been signalled before, is because the CI tests all run with fresh data seed where no-user hase accepted any AUP yet. The check then does no fire.

This correct logic is:


                    for a in person_object:
                        if a.startswith('voPersonPolicyAgreement'):
                            policy_agreement_attribute = True
                            break

@HarryKodden HarryKodden self-assigned this Nov 4, 2024
@HarryKodden HarryKodden moved this from New to To be tested in SRAM development Nov 5, 2024
@mrvanes
Copy link
Contributor

mrvanes commented Nov 13, 2024

Checked, SURFscz/plsc#140 can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To be deployed
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants