Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to different identifier for Services in PLSC #117

Closed
baszoetekouw opened this issue Nov 9, 2023 · 4 comments · Fixed by #123
Closed

Move to different identifier for Services in PLSC #117

baszoetekouw opened this issue Nov 9, 2023 · 4 comments · Fixed by #123
Milestone
v29

Comments

@baszoetekouw
Copy link
Member

Currently, services are identified by their entity_id in the ldap tree. The DNs look like dc=http://test.beta.sram.surf.nl/test1,dc=services,dc=sram,dc=surf,dc=nl for example.

This is annoying for two reasons:

  • sometimes the entity_id changes; this should not affect the ldap
  • entity_ids can be too complex to use in DNs (leads to escaping troubles)

Therefore, SBS will introduce a new ldap_identifier attribute for services (see SURFscz/SBS#1054). plsc should use this instead of the entity_id to build Service trees.
@FlorisFokkinga FlorisFokkinga changed the title Move to different identifier for Services ( Move to different identifier for Services Nov 17, 2023
@FlorisFokkinga FlorisFokkinga changed the title Move to different identifier for Services Move to different identifier for Services in PLSC Nov 17, 2023
@FlorisFokkinga FlorisFokkinga moved this from New to Todo in SRAM development Nov 17, 2023
@mrvanes
Copy link
Contributor

mrvanes commented Nov 17, 2023

Fixed in 8d26d71
image

@mrvanes mrvanes linked a pull request Nov 17, 2023 that will close this issue
Correctly handle disabled LDAP #122
Closed
@baszoetekouw
Copy link
Member Author

Works; only now it's very hard to distinguish different orgs. Please add objectclass=extensibleObject and a name (short_name) and displayName (name) to all top-level service objects.

@mrvanes
Copy link
Contributor

mrvanes commented Nov 22, 2023

Fixed in faadd9f but /api/plsc/sync does not contain service[short_name] so assigned entity_id for now.

@baszoetekouw baszoetekouw linked a pull request Nov 27, 2023 that will close this issue
Fix co cleanup2 #123
Merged
This was referenced Nov 27, 2023
Closed
Closed
@sram-project-automation sram-project-automation bot moved this from Todo to To be tested in SRAM development Nov 27, 2023
@baszoetekouw baszoetekouw added this to the v29 milestone Nov 27, 2023
@baszoetekouw baszoetekouw mentioned this issue Dec 6, 2023
Closed
@baszoetekouw
Copy link
Member Author

Service abbreviation is also exposed in SBS, so name in ldap is now filled with abbreviation:
Screenshot 2023-12-06 at 12 44 27

@baszoetekouw baszoetekouw moved this from To be tested to To be deployed in SRAM development Dec 6, 2023
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SRAM development
Archived in project
Milestone
v29
Development

Successfully merging a pull request may close this issue.

Fix co cleanup2 SURFscz/plsc
Correctly handle disabled LDAP SURFscz/plsc
3 participants
@baszoetekouw @HarryKodden @mrvanes