Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PDF filenames from the publisher's default #20

Open
brunj7 opened this issue Jun 15, 2018 · 2 comments
Open

Improve PDF filenames from the publisher's default #20

brunj7 opened this issue Jun 15, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@brunj7
Copy link
Member

brunj7 commented Jun 15, 2018

See if we can rename the file with more explanatory names

@brunj7 brunj7 added the enhancement New feature or request label Jun 15, 2018
@brunj7 brunj7 self-assigned this Aug 6, 2018
@nathanhwangbo nathanhwangbo self-assigned this Oct 18, 2019
@nathanhwangbo
Copy link

nathanhwangbo commented Oct 18, 2019

I started looking into this. My approach is just renaming the file using file.rename() in the for loop of article_pdf_download(). Thinking about using maybe publication year and first author?

@nathanhwangbo
Copy link

I have a partial implementation for this, which saves files using (name)(publication year)_(doi).pdf
We can't have backslashes in the filename, so I replaced the \ in the doi with ..

To do

I had to use regex to try and pull out the first author name. Some of the papers start with first name, and some start with last name though, so the name isn't consistent.

We can try to figure out how to consistently pull out the last name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants