Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces .bib file in output directory #26

Open
cristinasparks opened this issue Sep 5, 2018 · 2 comments
Open

Replaces .bib file in output directory #26

cristinasparks opened this issue Sep 5, 2018 · 2 comments

Comments

@cristinasparks
Copy link

If the output directory is the same as the input directory, and the .bib file is in that directory, running the package will remove the .bib file

@msleckman
Copy link

MS review:

Test 1: Scanned 10 publications related to the topic "windpower":
- 7/10 properly downloaded
- 3 are PDF, 4 are non-PDF
- Out of the 3 not successfully downloaded, two come from IEEE LATIN AMERICA TRANSACTIONS, one from INTERNATIONAL JOURNAL OF RENEWABLE ENERGY RESEARCH.
- One document downloaded file has no file name - called pdf.
- CSV looks like the output in R

Test 2: Scanned 10 publications related to the topic "drones conservation:
- 9/10 successfully downloaded
- 1 not successfully downloaded is derived from EUROPEAN RESEARCH CONSORTIUM INFORMATICS & MATHEMATICS. This pdf not easily accessible (not on google scholar)
- All chrome documents
- CSV looks like the output in R

Test 3: Scanned 10 publications related to the topic of "Yellowstone National Park":
- 9/10 successfully downloaded
- 1 not successfully downloaded is derived from JOURNAL OF PARK AND RECREATION ADMINISTRATION.
- None of the downloaded publications are pdfs - all are chrome links, most open a blank web page.
- CSV looks like the output in R

When the input bib file is stored in the "outdir" folder, all previous input files, including the bib file used to perform the download, are overwritten by the output files. Should fix or may consider placing a check to ensure input bib files and R outputs are kept separate.

@cristinasparks
Copy link
Author

cristinasparks commented Sep 6, 2018

If you remove line 117 crminer::crm_cache$delete_all() the .bib file stays in the folder, however it also leaves a weird unopenable .pdf in the folder. Working on figuring this out

  • If you repeat this process (with all the original files from the previous run), it crashes everything and creates 5-6 unopenable pdf files. It also deletes the .bib file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants