Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Tests broken #39

Open
clinkingdog opened this issue Oct 3, 2016 · 1 comment
Open

Tests broken #39

clinkingdog opened this issue Oct 3, 2016 · 1 comment
Labels
bug

Comments

@clinkingdog
Copy link
Contributor

My last commit, to add a new <link> element to the custom.css file, has broken the tests. Admittedly I should have checked before commit, but I really wouldn't expect this to break anything - it looks like the test is validating the entire HTML <head> against a template, which is way too specific and will mean breakages like this happen regularly.

Please come and chat to me (Nick) when starting this issue, to agree a plan for the correct fix.
@clinkingdog clinkingdog added the bug label Oct 3, 2016
@usmanatron
Copy link
Member

Ive just fixed the broken test as part of #38 - I agree though that its a bit too restrictive. Happy to discuss with you at some point!

@usmanatron usmanatron mentioned this issue Oct 26, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@usmanatron @clinkingdog