Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite deploy.sh to Ruby #6

Open
asbjornu opened this issue May 16, 2020 · 4 comments
Open

Rewrite deploy.sh to Ruby #6

asbjornu opened this issue May 16, 2020 · 4 comments

Comments

@asbjornu
Copy link
Contributor

asbjornu commented May 16, 2020

The deploy.sh script is becoming quite fat and since our container already has Ruby bundled, it would be better if the script was written in Ruby. Having the script in Ruby over Bash is better just in and of itself, but having it in Ruby would also allow us to add simple and fast RSpec tests for it instead of having to run the container for every little thing.

@asbjornu
Copy link
Contributor Author

asbjornu commented May 16, 2020

Seems like we have a few options to choose from:

Then we have ready GitHub Actions that aren't necessarily written in Ruby, but may still support what we need so we don't have to write and test it ourselves:

I'm a bit torn. None existing solutions seems to fit the bill perfectly. The Rake tasks are outdated and tailored towards Travis. Perhaps we could fork one of them?

The GitHub Actions don't really help us in any way, since they are written in Bash, only the first one have tests and I think we would need to fork or pull-request them to support our needs.

@asbjornu
Copy link
Contributor Author

I just discovered GitHub Pages Action that is written in TypeScript and seems very full-featured.

@NullableInt
Copy link
Contributor

I just discovered GitHub Pages Action that is written in TypeScript and seems very full-featured.

Nice find!

@asbjornu asbjornu changed the title Rewrite gh-pages-publish to Ruby Rewrite deploy.sh to Ruby Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@asbjornu @NullableInt and others