Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Empty page on filtering with filter with no tags #551

Open
johannaengland opened this issue Apr 10, 2024 · 1 comment
Open

Bug: Empty page on filtering with filter with no tags #551

johannaengland opened this issue Apr 10, 2024 · 1 comment
Labels
bug Something is not working as expected

Comments

@johannaengland
Copy link
Contributor

johannaengland commented Apr 10, 2024

Describe the bug
I have a filter that looks like this when getting api/v1/notificationprofiles/filters/3/

{
  "pk": 3,
  "name": "NAV",
  "filter_string": "{\"sourceSystemIds\": [1], \"tags\": []}",
  "filter": {
    "sourceSystemIds": [
      1
    ],
    "open": null,
    "acked": null,
    "stateful": null,
    "maxlevel": null,
    "event_type": null
  }
}

and like this for api/v2/notificationprofiles/filters/3/

{
  "pk": 3,
  "name": "NAV",
  "filter": {
    "sourceSystemIds": [
      1
    ],
    "open": null,
    "acked": null,
    "stateful": null,
    "maxlevel": null,
    "event_type": null
  }
}

Note that in the filter field there is no entry for tags, which is valid for the backend.

When I try to filter by this filter I only get an empty page and I also see that no request to the backend is being made.

To Reproduce
Steps to reproduce the behavior:

  1. Post a filter with no tags to the backend via the api (do not do it via the frontend, because then tags will be an empty list) with this content:
{
  "name": "test",
  "filter": {
    "sourceSystemIds": [
      1
    ]
  }
}
  1. Now in the frontend: Select that filter.
  2. See empty page.

Expected behavior
To be shown the normal dashboard with the incidents included in that filter.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: Ubuntu 22.04 LTS
  • Browser: Firefox
  • Version: both 1.12.0 and 1.13.0
@johannaengland johannaengland added the bug Something is not working as expected label Apr 10, 2024
@podliashanyk
Copy link
Contributor

Reproduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected
Projects
None yet
Development

No branches or pull requests

2 participants