Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview URL #12

Open
Thunder33345 opened this issue Apr 12, 2023 · 0 comments
Open

Fix preview URL #12

Thunder33345 opened this issue Apr 12, 2023 · 0 comments
Assignees

Comments

@Thunder33345
Copy link
Collaborator

Thunder33345 commented Apr 12, 2023

currently cf deploy action's preview URL is broken. Example: https://1ada3338.vaccinator-wiki.pages.dev/ from /runs

this could be fixed on the cf pages panel to use ENV vars instead of hardcoding the domain in the config

Example hugo -b $CF_PAGES_URL --minify --gc --environment $VAR_DEPLOY_MODE

something like -b $CF_PAGES_URL will allow cf to dynamically tell hugo what the site url actually is, this is needed for CROS, scripts and resources to work properly(so it will load from the respective dev branch)

we could set the production variable of $CF_PAGES_URL to be hardecoded to our main domain, and blank prefill for dev env

This issue is currently blocking proper deploy flow(having a staging env and a protected main branch where everything has to be added via PR)

nice to have that needs thinkering: visiting our root https://vaccinator-wiki.pages.dev should redirect to https://wiki.vaccinator.tech/ (realistically we wont be using that link so it's not a priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants