-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The headline is not in the right place. #64
Comments
I’d like to help fix it, but I could use a bit more info:
I’ve tried reproducing the issue on my end with the same icon and text, but I didn’t notice any problems. Maybe I’m missing something. Let me know, and I can start working on this. |
I've noticed it with the official site on smaller screens (on components > package manager) |
I found the problem, and it doesn't seem like a real or actual problem.
That said, it is fixable but... is it really worth it? |
Speak for yourself, plenty of people browse the internet on mobile (especially in places like China). That said, this is still a really small problem. |
As you mentioned, the issue is minor and small! However, as you can see, I am on the desktop, and when I increase the submenus, they are displayed correctly in normal mode. But when the mouse hovers over them, they turn red. This hover effect has become extremely thin, and unlike the others, there's no extra space around it for aesthetic purposes. This happens even when there's some protrusion, and in the first image I sent, I was on the desktop, not on mobile! You can see that the word "Google Dorking" has clearly protruded. VS. |
it makes sense. |
@YasinSpace I'm working on it now, i'll open a PR soon. Ignore the item names and section, I simply pasted the sections to simulate many sub-menus. |
Which means this is more of an issue with organization than anything else. If you have that many subsections you may need to reorganize your pages. (Folders with a This should be a choice or conditional. |
Yes of course it's optional, that's a new prop to the aside in the app config. |
Do you have any suggestions? I think this solves the problem presented by @YasinSpace , if you want to have 20 levels of indentation you will have tradeoffs obviously. |
obv. introduction should be a root-level folder. The Methodologies section seems to be their attempt to create section index pages (which the theme should have, but doesn't) and should be reworked with less sections (i.e. do we need to specify pentesting methodologies under methodologies when we only discuss pentesting?) edit: there's a reason the official docs do not use many subfolders, they're organized properly. |
Having introduction as root-level is ok, but the problem remains. You have only removed 1 level of indentation no? |
It's possible to remove more by cutting out subfolders. I explained we can cut out methodologies for pentesting as well. (methodologies too since that would be a root-level folder) That would likely be enough to fix the issue (still nice to have that option tho). |
Yes, I understand the meaning and I agree that it is better, but I don't have the time to do it now. |
You didn't make the site? The OP did. |
No i didn't edit: ok no, maybe it makes more sense to wait and do it as you say. |
Describe the feature
As you can see,
the state in the title is not positioned correctly when we click on a title!
And specify this or add in the feature: Please add this : in config file we can change the size of the sidebar, for example, set it more forward or more backward ( resize ) by default. =)
Additional information
The text was updated successfully, but these errors were encountered: