Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Shikimori #474

Closed
imKota opened this issue Jul 28, 2021 · 8 comments
Closed

Add support Shikimori #474

imKota opened this issue Jul 28, 2021 · 8 comments

Comments

@imKota
Copy link

imKota commented Jul 28, 2021

Please add support Shikimori
It uses data from the animeist (the same id as in mal), but this data is translated into Russian.

https://shikimori.one/api/doc/1.0
Anime page doc:
https://shikimori.one/api/doc/1.0/animes/show
Anime page sample:
https://shikimori.one/api/animes/48488

Related page doc:
https://shikimori.one/api/doc/1.0/animes/related
Related page sample:
https://shikimori.one/api/animes/48488/related

Screenshots page doc:
https://shikimori.one/api/doc/1.0/animes/screenshots
Screenshots page sample:
https://shikimori.one/api/animes/48488/related

Roles page doc:
https://shikimori.one/api/doc/1.0/animes/roles
Roles page sample:
https://shikimori.one/api/animes/48488/roles

@ZeroQI
Copy link
Owner

ZeroQI commented Jul 28, 2021

There is no mapping with ANiDB nor TheTVDB, technically AniDB could provide MALid but cannot see what benefits it brings, especially if it's just ANimeList information translated...

I see no way to include that with reliable mapping into HAMA, which will stop having major functionality anytime soon when TheTVDB stops the free API access...

@ZeroQI ZeroQI closed this as completed Jul 28, 2021
@imKota
Copy link
Author

imKota commented Jul 28, 2021

There is no mapping with ANiDB

@ZeroQI There is a comparison with other sites(mal, ann, anidb, wa).

doc:
https://shikimori.one/api/doc/1.0/animes/external_links
sample:
https://shikimori.one/api/animes/48488/external_links

@ZeroQI
Copy link
Owner

ZeroQI commented Jul 28, 2021

We can map from the MALid (if AniDB provides it) to anidb https://shikimori.one/api/animes/48488/external_links but cannot find any episode information...

What fields are provided by that, which are better than the actually already supported, and how is that support to be added more important than the impeding TVDB doom as soon as they cut the plug to the API by requiring subscription?

@imKota
Copy link
Author

imKota commented Jul 28, 2021

Doesn't anidb store episode information?
I remember that these data are available there.

https://wiki.anidb.net/Content:Episodes
https://anidb.net/anime/16137

1st ep
https://anidb.net/episode/241203
1st ep file info
https://anidb.net/file/2802239

@ZeroQI
Copy link
Owner

ZeroQI commented Jul 28, 2021

Why should i work on that?

  • What fields are so badly handled by current metadata providers currently that i have to add yet another metadata source ?
  • Please document which fields are impacted by this bad metadata and how this additional potential metadata source solves it
  • HAMA will lose TheTVDB as metadata source when they disable legacy APIs [https://github.com/TheTVDB v4 licensing and HAMA future #457]. How is this request more important ?

@imKota
Copy link
Author

imKota commented Dec 25, 2021

Why should i work on that?

  • Please document which fields are impacted by this bad metadata and how this additional potential metadata source solves it

Hello, @ZeroQI
On the Shikimori, everything is translated into Russian, including descriptions, character names, seiyu, directors, etc.
It would be nice to add support for the Russian language. Since there are no translated names on mal/anidb, and everything on Shikimori.

@ZeroQI
Copy link
Owner

ZeroQI commented Dec 26, 2021

Hama uses mainly AniDB or TheTVDB ID as unique ID and AnimeList to do a perfect mapping of the episodes between both regardless if the series follow AniDB and TheTVDB numbering.

This metadata source follow MaL ID so asking Meal developper to add support is more feasible as even if this metadata source has full metadata entered, MaL numbering will differ for some series with AniDB and TheTVDB so will create mismatched data. Even having AniDB or TheTVDB I'd from that source will not solve this mapping issue

TheTVDB supports Russian so ideally one would enter metadata for series there, but it will pass behind a paywall any month now...

@imKota
Copy link
Author

imKota commented Dec 26, 2021

Hama uses mainly AniDB or TheTVDB ID as unique ID and AnimeList to do a perfect mapping of the episodes between both regardless if the series follow AniDB and TheTVDB numbering.

This metadata source follow MaL ID so asking Meal developper to add support is more feasible as even if this metadata source has full metadata entered, MaL numbering will differ for some series with AniDB and TheTVDB so will create mismatched data. Even having AniDB or TheTVDB I'd from that source will not solve this mapping issue

TheTVDB supports Russian so ideally one would enter metadata for series there, but it will pass behind a paywall any month now...

hmm.. but all anime no shiki have mappings with anidbhttps://shikimori.one/api/animes/48488/external_links

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants