Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equihash verification #5

Open
L0gi opened this issue Apr 8, 2018 · 1 comment
Open

equihash verification #5

L0gi opened this issue Apr 8, 2018 · 1 comment

Comments

@L0gi
Copy link

L0gi commented Apr 8, 2018

Hi,

I assume this is the origin of this equihash implementation port to c I have stumbled upon in several other projects?

If so, I believe my request is best directed and solved here.

Am I missing something, or does this port not verify the algorithm binding condition (strict (i.e. no duplication in indices) lexicographical ordering + leading zeroes in 'subsolutions')?

Given that several mining pool projects seem to have adopted this code, I could see there being potentially some problems depending on how their share payout is set up, if rogue miners decide to take advantage of amortization costs submitting solutions that wouldn't be accepted by the network, but this verifier code seems to allow.

@aabc
Copy link
Owner

aabc commented Apr 8, 2018

It's assumed that Wagner's algorithm provides just the correctly bound solutions.

I also doubt that many miners use this implementation since there is already (in 2016) much more optimized versions after competition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants