Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACPI patches match normalized IDs #2446

Open
mhaeuser opened this issue Nov 18, 2024 · 1 comment
Open

ACPI patches match normalized IDs #2446

mhaeuser opened this issue Nov 18, 2024 · 1 comment
Labels
bug Something isn't working priority:low project:oc

Comments

@mhaeuser
Copy link
Member

When the quirk NormalizeHeaders is enabled, IDs matched by ACPI -> Patch are compared to the normalized IDs. This is undocumented, the normalization algorithm is not detailed and normalized IDs appear to not be printed in the log. While it might make sense to preserve the current behaviour and adjust the documentation, I'm not sure anyone really relies on this over just using the wildcard. It is worth noting that toggling the quirk will break or restore the affected ACPI patches for no obvious reason.

Initially reported by CorpNewt.
@mhaeuser mhaeuser added bug Something isn't working project:oc priority:low labels Nov 18, 2024
@mhaeuser
Copy link
Member Author

Interestingly, the initial code worked as expected: acidanthera/OpenCorePkg@7f528ca#diff-2dac234d8b20e76b94e408613d05c5d32dea3af9a0361b2a73cd5d1e63c1335cR153-R165

The bug was introduced by: acidanthera/OpenCorePkg@f604848#diff-64f173a3dceca8c36f31ffc4f0ea07e76136fdc048dc52a7f23406f41b3d6192R245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:low project:oc
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhaeuser