-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression with v7 when trying to iterate over pull requests. #448
Comments
We're having the same issue! @Miepee did you find a solution yet? |
Not really. I just downgraded to v6. |
There is an upstream regression in v7. Use v6 until Node 16 is still available. See: actions/github-script#448
There is an upstream regression in v7. Use v6 until Node 16 is still available. See: actions/github-script#448
Not sure if it will work for you, but I found that adding console.log('Getting Pull Request Commits:')
- const commits = await github.rest.pulls.listCommits({
+ const commits = await github.rest.pulls.listCommits.endpoint.merge({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: ${{ github.event.number }}
}) From what I can find, this was actually the method we should use. See this example: https://github.com/marketplace/actions/github-script#welcome-a-first-time-contributor |
There is an upstream regression in v7. Use v6 until Node 16 is still available. See: actions/github-script#448
I am too seeing this issue. |
Describe the bug
When trying to iterate over pull requests with gh-script v7, it throws. This did not happen with v6.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The runner should not throw, and the log statement should get printed.
Current behaviour
The runner throws. Stacktrace:
The text was updated successfully, but these errors were encountered: