Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Add [tool name] #4972

Closed
5 of 9 tasks
kdschlosser opened this issue Jan 29, 2022 · 3 comments
Closed
5 of 9 tasks

Update/Add [tool name] #4972

kdschlosser opened this issue Jan 29, 2022 · 3 comments

Comments

@kdschlosser
Copy link

Tool name

Ninja

Tool license

Apache License, Version 2.0

Add or update?

  • Add
  • Update

Desired version

latest

Approximate size

No response

Brief description of tool

It would be nice to have Ninja available for Darwin and also Linux builds. Ninja is available on the Windows builds as it is apart of the Visual Studio cmake installation. cmake is installed on both Darwin and Linux and having Ninja would make it easier to facilitate multicore compiling.

URL for tool's homepage

https://ninja-build.org/

Provide a basic test case to validate the tool's functionality.

cmake -GNinja -S"/path/to/source/files"  -B"/path/to/place/cmake/files"
ninja -C"/path/to/source/files" -j 4

Virtual environments affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.15
  • macOS 11
  • Windows Server 2016
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

if homebrew is available

brew install ninja

Tool installation time in runtime

don't know

Are you willing to submit a PR?

I would if I knew how to go about it

@dibir-magomedsaygitov
Copy link
Contributor

Hello @kdschlosser. Thank you for your request. We will consider adding this tool to our images. Meanwhile, could you please correct the title.

@dibir-magomedsaygitov
Copy link
Contributor

Hello @kdschlosser. Due to maintenance concerns, fast and easy installation in runtime, we wouldn't like to add ninja to our macOS and ubuntu images.
I'm going to close the issue, but feel free to contact us if you have any concerns.
Thank you!

@marc-hb
Copy link

marc-hb commented Dec 22, 2024

thanks for your suggestion but considering that it' easy to add Ninja to workflows on demand,...

I just asked runtime installation to be officially documented, please upvote:

Ever growing list of duplicates gathered at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants