From 20b214419a43b5cc2337627438e9227a2d5b2c82 Mon Sep 17 00:00:00 2001 From: Timotej Ecimovic Date: Tue, 26 Nov 2024 13:25:59 -0500 Subject: [PATCH] Improve the out-of-date warning message. In case of self-hosted runner, the organization uses the GitHub runner, but they also have their own self-hosted runner "version", with specific configuration being improved over time and through this increasing their own internal "runner version". The way the message was written, sometimes results in confusion, where developer and a devops person start mistakenly assuming that the version is related to their own runner version, and not the actual GitHub runner that runs on that hardware. Time is then lost, until someone realizes that this has nothing to do with the internal "runner version" itself, but with the actual GitHub runner that needs to be upgraded. Message was fixed to explicitely differentiate between "GitHub runner" and the self-hosted runner itself to avoid possible confusion and possibly save someone few minutes of time. --- src/Runner.Worker/JobRunner.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Runner.Worker/JobRunner.cs b/src/Runner.Worker/JobRunner.cs index 7ab506a53b2..4391c0841d5 100644 --- a/src/Runner.Worker/JobRunner.cs +++ b/src/Runner.Worker/JobRunner.cs @@ -511,7 +511,7 @@ private async Task WarningOutdatedRunnerAsync(IExecutionContext jobContext, Pipe if (result == TaskResult.Failed && warnOnFailedJob) { - jobContext.Warning($"This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version {currentVersion}. Please update to the latest version {serverPackages[0].Version}"); + jobContext.Warning($"This job failure may be caused by using an out of date version of GitHub runner on your self-hosted runner. You are currently using GitHub runner version {currentVersion}. Please update to the latest version {serverPackages[0].Version}"); } else if (warnOnOldRunnerVersion) {