-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache Maven distribution downloaded by Maven Wrapper #448
Comments
Hi, @Marcono1234 👋 Thank you for the feature request! We will investigate it and get back to you with our decision as soon as possible. |
@IvanZosimov I submitted #453 for this |
it's runing |
@yeikel Hi, maybe you can support gradlew also, this is really useful of cache mvnw and gradlew |
I think that we should track that separately |
You are right, maybe not work of cache gradlew due to excessive cache size, i find it work just now. |
Description:
Cache the Maven distribution downloaded by the official Maven Wrapper.
The cache key should probably be derived from the
.mvn/wrapper/maven-wrapper.properties
file (see documentation), similar to how it is done already for the Gradle Wrapper.The directory to cache is
~/.m2/wrapper/dists
(see documentation).Justification:
Without caching, projects using the Maven Wrapper would have to download the Maven distribution (~8MB) every time the project is built.
For Gradle the setup-java action already supports caching the Gradle distribution downloaded by the wrapper:
setup-java/src/cache.ts
Line 36 in 8f12c5c
setup-java/src/cache.ts
Line 32 in 8f12c5c
Are you willing to submit a PR?
Probably not
The text was updated successfully, but these errors were encountered: