Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new @actions/cache missing @protobuf-ts/runtime #1898

Open
kamontat opened this issue Dec 8, 2024 · 0 comments
Open

The new @actions/cache missing @protobuf-ts/runtime #1898

kamontat opened this issue Dec 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kamontat
Copy link

kamontat commented Dec 8, 2024

Describe the bug

New @actions/cache v4.0.0 contains generated protobuf typescript that depends on @protobuf-ts/runtime. However, it not defined on package.json file.

To Reproduce

  1. Install new @actions/cache v4.0.0
  2. Bundle using any bundlers (I used esbuild)
  3. Got Cannot find module '@protobuf-ts/runtime-rpc' from 'node_modules/.pnpm/@actions+cache@4.0.0/node_modules/@actions/cache/lib/generated/results/api/v1/cache.js' error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

When I run build typescript:

CleanShot 2024-12-08 at 18 09 09@2x

When I run jest test:

CleanShot 2024-12-08 at 18 08 52@2x

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: -
  • Version: -
  • NodeJS: v20.14.0
  • pnpm: v9.12.1

Additional context
Add any other context about the problem here.

@kamontat kamontat added the bug Something isn't working label Dec 8, 2024
kamontat added a commit to kc-workspace/kcws-js that referenced this issue Dec 8, 2024
mergify bot pushed a commit to kc-workspace/kcws-js that referenced this issue Dec 8, 2024
* fix(deps): upgrade dependencies [auto]

* chore(core): update changefiles

* fix(heft-esbuild-plugin): add protobuf runtime dependencies as external dependencies

* fix(heft-node-rig): update github-actions rig to support new v4 actions/cache with protobuf

* fix: add protobuf to spelling whitelist

* fix(deps): rollback @actions/cache version to mitigate

visit actions/toolkit#1898 for more information

---------

Co-authored-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant