Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odl issue #6

Open
iamimage opened this issue Jun 21, 2019 · 4 comments
Open

odl issue #6

iamimage opened this issue Jun 21, 2019 · 4 comments

Comments

@iamimage
Copy link

Hi Adler, it looks strange when I tried to run "learned_primal_dual/human/mayo_learned_primal_dual.py". Here is the error massage:

===================================================================
20 size = 512
21 space = odl.uniform_discr([-128, -128], [128, 128], [size, size],
---> 22 dtype='float32', weighting='const')
.....................
odl/space/weighting.py in init(self, const, impl, exponent)
591 """
592 super(ConstWeighting, self).init(impl=impl, exponent=exponent)
--> 593 self.__const = float(const)
594
595 if self.const <= 0:

ValueError: could not convert string to float: 'const'

I supposed I do not install the correct version of odl? when I "pip list | grep odl"
odl 1.0.0.dev0
Did you update the code of this odl version? or how do I get the correct version of odl for runing?

@adler-j
Copy link
Owner

adler-j commented Jun 23, 2019

Thanks for reporting this. I've updated the repo with a new version where this should be fixed. Please report of you have any issues moving forward.

@iamimage
Copy link
Author

Thanks for reporting this. I've updated the repo with a new version where this should be fixed. Please report of you have any issues moving forward.

Many thanks for the update. I try to run the code (mayo_learned_primal_dual.py) again but this time it fails to find the object 'odl.tomo.FanFlatGeometry'. I can not find the definition of 'FanFlatGeometry' in the 'odl 1.0.0.dev0' document either. Is it removed at some release somehow?

Another question that I am really interested: is the layer made from as_tensorflow_layer expected to perform on GPU during training? I run also the code ellipses/learned_primal_dual.py. It was successful, but the GPU-Util is zero most of the time, while 2%~5% for the rest. So I am wondering whether one or more parts of the job is not on GPU.

@Mojzaar
Copy link

Mojzaar commented Jun 6, 2021

Thanks for reporting this. I've updated the repo with a new version where this should be fixed. Please report of you have any issues moving forward.

Many thanks for the update. I try to run the code (mayo_learned_primal_dual.py) again but this time it fails to find the object 'odl.tomo.FanFlatGeometry'. I can not find the definition of 'FanFlatGeometry' in the 'odl 1.0.0.dev0' document either. Is it removed at some release somehow?

Another question that I am really interested: is the layer made from as_tensorflow_layer expected to perform on GPU during training? I run also the code ellipses/learned_primal_dual.py. It was successful, but the GPU-Util is zero most of the time, while 2%~5% for the rest. So I am wondering whether one or more parts of the job is not on GPU.

I have the same issue here for "odl.tomo.FanFlatGeometry". Did you find the solution?

@99991
Copy link

99991 commented Jan 27, 2023

It seems like this pull request renamed FanFlatGeometry to FanGeometry. As a solution, I installed an older version of odl where the pull request had not been merged yet.

pip install https://github.com/odlgroup/odl/archive/0a2dac2a68be3a06e72b4559f9026c206ccad46e.zip

Not sure if this is the correct version, but at least I get different errors now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants