Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate check for consistent upstream dependencies #1252

Open
jakob-keller opened this issue Dec 31, 2024 · 1 comment
Open

Automate check for consistent upstream dependencies #1252

jakob-keller opened this issue Dec 31, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@jakob-keller
Copy link
Collaborator 

          By the way, you should be able to write a simple check built into the pre-commit framework, verifying that these values are the same. Here's an example of embedding a few lines of python there: https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/648f815/.pre-commit-config.yaml#L45-L74.

Originally posted by @webknjaz in #1246 (comment)
@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Dec 31, 2024
@jakob-keller jakob-keller mentioned this issue Dec 31, 2024
Merged
13 tasks
@webknjaz
Copy link
Member

webknjaz commented Jan 1, 2025

Or are you suggesting to merely check that those three lines are always touched at the same time?

Yes, this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webknjaz @jakob-keller