Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in removing all / single subscriber #30

Open
tbusser opened this issue Sep 1, 2014 · 0 comments
Open

Difference in removing all / single subscriber #30

tbusser opened this issue Sep 1, 2014 · 0 comments

Comments

@tbusser
Copy link
Contributor

tbusser commented Sep 1, 2014

I was looking at the removeSubscriber method of the Channel object and I noticed something that I can't explain.

When removing a specific subscriber you set the channel property of the subscriber to null before removing it from the array of subscribers. When all the subscribers get cleared due to the id param being null the array is simply cleared and the channel property on all the subscribers don't get reset to null.

Is there a specific reason for this or is it an oversight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant