Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes "Skip" button is replaced by "go back" while teh segment is still playing #2160

Closed
JohnTheCoolingFan opened this issue Nov 19, 2024 · 8 comments

Comments

@JohnTheCoolingFan
Copy link

изображение

In the image above, the widget that appears when watching a segment that you can skip, has a "Go back" (Назад) button instead of "Skip" (Пропустить). Clicking it will move you to the start of segment, just as the button's text suggests. When using enter, the segment gets skipped properly.

I'm using Firefox 132.0.2 on Linux via flatpak and SponsorBlock 5.9.6, had this problem for a while but didn't report as I usually use Enter to skip.

I did look for similar issues but haven't found one.

Debug information: https://gist.github.com/JohnTheCoolingFan/86d528dea7261dc54e790cdf39e0f322

@Aspireve
Copy link

Heyy Hi!!
Could I try sorting this issue. I just had a look at the code and understood what might be wrong with it

@ajayyy
Copy link
Owner

ajayyy commented Nov 27, 2024

@Aspireve sure!

@Aspireve
Copy link

Heyy Hi!!

I checked through the app, but it seemed to be working just fine, A recording of its working on my PC (this is on Firefox)

WhatsApp.Video.2024-11-27.at.18.07.51.mp4

I guess it might be that the mouse might have lost the calibration and causing a multiple click

@TheNoFace
Copy link

It happens to me, and it's been around for some while. It shows Unskipbutton first, not Skip. If I tries to skip using keyboard shortcut, it skips normally, but if I press Unskip button, it just turns into Reskip button and do not skip the segment.

It happens only on Firefox, Chrome version works as intended.

  • Initial popup
    image

  • After pressing unskip button manually
    image

  • Versions

    • Firefox 133.0.3
    • Sponsorblock 5.10.1

@ajayyy
Copy link
Owner

ajayyy commented Dec 11, 2024

It only happens before the video starts?

@TheNoFace
Copy link

It only happens before the video starts?

It happens on every segment popups, including manual skip and automatic skip.

@ajayyy ajayyy closed this as completed in 557e2ea Dec 11, 2024
@ajayyy
Copy link
Owner

ajayyy commented Dec 11, 2024

Found the issue

@JohnTheCoolingFan
Copy link
Author

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants