Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubToken can't be blank #10

Open
ghost opened this issue Jan 15, 2020 · 5 comments
Open

GitHubToken can't be blank #10

ghost opened this issue Jan 15, 2020 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 15, 2020

I see the error message "Parameter GitHubToken should either have input value or default value" at the top of the review page for creating a stack. I haven't entered a value for the GitHubToken field because I want CloudFormation to create me a repository in CodeCommit. Is anyone else seeing this problem?

@ghost
Copy link
Author

ghost commented Jan 15, 2020

kelseyhightower/confd#719 might have some relevance to this problem.

@ghost
Copy link
Author

ghost commented Jan 16, 2020

I don't know what the correct Cloudformation syntax is for this, but if I were writing it in Java, I think I'd try the following on line 513: OAuthToken: gitHubToken.length() > 0 ? gitHubToken : "". In English: if the length of the value in GitHubToken is greater than zero, pass GitHubToken, otherwise pass an empty string.

@ghost
Copy link
Author

ghost commented Jan 16, 2020

My hack to get around the problem: on line 142, I changed the 'Type:' of GitHubToken from 'AWS::SSM::Parameter::Value' to 'String' and the problem went away. That only works for the case where you don't specify a value for GitHubToken, so it's not a proper solution, but it kept me going, and might help someone else who's blocked on this problem.

@ehammond
Copy link
Member

Thanks for taking the time to report this problem. I don't know when I'll be looking at this code next, but if anybody can confirm issues or propose solutions, it would be welcomed.

@ghost
Copy link
Author

ghost commented Apr 20, 2021

I've switched from @condorsf to @rkawala, in case anyone wants to update me about this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant