Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New strategy to trigger release? #714

Open
eunjae-lee opened this issue Mar 9, 2020 · 0 comments
Open

New strategy to trigger release? #714

eunjae-lee opened this issue Mar 9, 2020 · 0 comments

Comments

@eunjae-lee
Copy link
Contributor

List pull requests associated with commit

For now, the condition to trigger release is

correctCommitMessage && correctBranch

(https://github.com/algolia/shipjs/blob/master/packages/shipjs-lib/src/lib/config/defaultConfig.js#L88-L107)

What if it becomes

(correctCommitMessage || prLabeled) && correctBranch

prLabeled here means if the PR associated with the latest commit message has a specific label like "release:trigger".

This might solve issues like #667

Is there any side effect?

Should it become a default behavior? or an opt-in feature?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eunjae-lee