Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding the API URL in the client is fragile #137

Open
andyhd opened this issue Aug 30, 2023 · 0 comments
Open

Overriding the API URL in the client is fragile #137

andyhd opened this issue Aug 30, 2023 · 0 comments
Assignees
@andyhd
Labels
enhancement New feature or request

Comments

@andyhd
Copy link
Contributor

andyhd commented Aug 30, 2023

If we set a data-consent-api-url attribute on any element in the DOM, it will be used to override the URL that the client JS uses for API queries. This is useful for running in different environments.

There is no defensive coding around the use of the data attribute value. This should be considered user input and treated carefully.
@andyhd andyhd added the enhancement New feature or request label Aug 30, 2023
@andyhd andyhd self-assigned this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyhd andyhd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andyhd