Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pydantic v2 #161

Closed
max-radin opened this issue Oct 10, 2023 · 10 comments
Closed

Support for pydantic v2 #161

max-radin opened this issue Oct 10, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@max-radin
Copy link
Collaborator

Describe the feature you'd like
Support for at least one 2.X.X version of pydantic.

How would this feature be used? Please describe.
Adding support for pydantic v2 would allow us to upgrade orquestra-sdk to also use pydantic v2 and benefit from the improvements it offers.

The reason for this is that the orquestra-core metapackage depends on pydantic transitively through orquestra-sdk as well as amazon-braket-default-simulator and amazon-braket-schemas-python. So currently, upgrading orquestra-sdk to pydantic v2 would create a dependency conflict for orquestra-core.

Describe alternatives you've considered
Our current strategy is to continue using pydantic < 2.0.0.

@guomanmin
Copy link
Contributor

Hi @max-radin - thanks for raising this, we're looking at a couple of options before getting back.

@speller26
Copy link
Member

Hello! We're not going to pursue this upgrade for the time being, but feel free to leave the issue open so we may revisit it in the future.

@vanyae-cqc
Copy link

Hello! Just a heads up that this is also a blocker for me and my team. Any movement would be very much appreciated

@tachikoma-li
Copy link

tachikoma-li commented Jan 15, 2024

Just to echo the comments above, it would be great that braket could support Pydantic 2. It seems #163 has already done the work by updating the import to pydantic.v1, as recommend by the official doc if we don't want to spend too much time to fully migrate to 2.0.

@AbeCoull
Copy link
Contributor

Hello all,

The team is currently exploring options to make these upgrades, we will post more information in this thread when we have an update.

@amazon-braket amazon-braket deleted a comment from AbeCoull Jan 24, 2024
@richrines1
Copy link

hi, by any chance is there a timeline for this? it will soon be a blocker for us

thanks :)

@vanyae-cqc
Copy link

vanyae-cqc commented Mar 15, 2024

+1 Unfortunately we've had to drop support for Braket in our stack until it can support Pydantic V2. Thanks for taking a look at this and look forward to supporting Braket again soon 🙏

@AbeCoull
Copy link
Contributor

Hey All,

Thank you for your patience with us! The fix for Pydantic 2.x has been released for the schemas repository. Amazon Braket is continuously looking to prioritize bug fixes and develop mechanisms to address issues as they arise.

Internally, we are developing an approach to get better tracking of open-source issues. Reach out with any additional questions or open a new issue for additional feature requests and support.

@richrines1
Copy link

tysm @math411!!

@vanyae-cqc
Copy link

Thank you @math411 and team! We will immediately start working to support Braket again ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants