Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support find_by_name for Organizations #6

Open
rmorlok opened this issue Nov 7, 2018 · 9 comments
Open

Support find_by_name for Organizations #6

rmorlok opened this issue Nov 7, 2018 · 9 comments

Comments

@rmorlok
Copy link

rmorlok commented Nov 7, 2018

Currently, the person class supports find_by_name, but this is also available in the API for organizations. Please add support for that class as well.

@rmorlok
Copy link
Author

rmorlok commented Nov 7, 2018

Ah, sorry, this already exists. It looks like the gem just hasn't been updated. Could we get a new version of the gem?

Thanks!

@choosen
Copy link
Contributor

choosen commented Apr 1, 2019

I think it's resolved

We use finding organisations by term (this means also in other string fields)

@rmorlok
Copy link
Author

rmorlok commented Apr 1, 2019

So term searches beyond just the name? This would be good for some cases, but not if you are specifically searching by name.

Per my second comment, the code actually supports searching by name, a new release of the gem just hasn't been pushed since that change was made. Can you push a new version of the gem?

@choosen
Copy link
Contributor

choosen commented Apr 1, 2019

Yeah, term aims in different fields also.

This is gem which uses public API

there is no other way to query it according to:
https://developers.pipedrive.com/docs/api/v1/#!/Organizations/get_organizations_find

@rmorlok
Copy link
Author

rmorlok commented Apr 1, 2019

Ah, I see what you mean. The find_by_name method is actually implemented as a term search, regardless.

Perhaps I'm missing something, but I'm not seeing anything in the ruby code for how to do a term search for an organization. If you could point me to it, I'd appreciate it.

Per my previous messages, there is the following code which is labeled as find_by_name (which does the term search), but it is not part of the current version of the gem, and I was hoping you could release it as a new version.

https://github.com/amoniacou/pipedrive.rb/blob/master/lib/pipedrive/organization.rb#L9

@choosen
Copy link
Contributor

choosen commented Apr 1, 2019

oh true that, it's not released ; /

merged 3 years ago

we use
gem 'pipedrive.rb', git: 'https://github.com/amoniacou/pipedrive.rb.git'

@9211ali
Copy link

9211ali commented May 14, 2023

@rmorlok @choosen,
Can you share example of find_by_name example for organization.
And how to find unique organization using unique attributes i.e. name or other field. kindly guide about it.

when I try by name,
client = ::Pipedrive::Organization.new(ENV[‘PIPEDRIVE_API_TOKEN’])
client.find_by_name(‘name’) , it return result like
#<Enumerator: #<Pipedrive::Organization:0x00007f06a0ab8210 @api_token=“my_api_token”>:find_by_name(term: name)>

image

@choosen
Copy link
Contributor

choosen commented May 17, 2023

sorry , not in the project with pipedrive anymore. Cannot paste it

@rmorlok
Copy link
Author

rmorlok commented May 17, 2023

Unfortunately I don't have access to the project using pipedrive as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants