Gradle lintage

[mikehardy]

Purpose / Description

When there's too much noise I can't see the signal, so took a pass at quieting our build down

Also, we're ready for gradle 9 now

Fixes

Nothing logged - but the final result is that there are zero gradle warnings except about tools:replace not replacing anything

Approach

Ran all the main build targets with --warning-mode=all and fixed them, also looked at the manifest merger warnings

How Has This Been Tested?

By re-running the tasks, and checking file perms on pre-commit hook

Learning (optional, can help others)

It is not possible to quiet the build warning from a tools:replace manifest merger when there was nothing to replace

It seems that the merger happens in priority order, and since it comes from a library, my attempt to define a dummy entry in our app manifest (that would be replaced, quietly) did not work as the replace warning already happened when the library attempted to do it first, without getting to the app manifest yet

the only thing I think could be done is make a tiny dummy library that defines the replaced items but that's a lot of work for little gain

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[mikehardy]

group and other need no change, it's user that's important so that the commit hook works
verified it works still after this

[david-allison]

Merge at will!

[david-allison]

It might be time to remove amazon for good. I've stopped listing it on release annoucnements.

[mikehardy]

contemplated this before, re-contemplated it just now, here's what I saw in research:

• store still seems viable: amazon app store is definitely smaller than google play store, however it's still approx 20% the size
  • https://www.statista.com/statistics/276623/number-of-apps-available-in-leading-app-stores/
• lots of users still locked in: amazon devices which are quite popular get amazon app store by default and you can install play store but it is a bunch of manual steps that is high barrier to entry
• publishing actually seems very close to possible again:
  • people seem to find success with jitpack using master: nova-video-player/aos-Video@d36587c
  • but we have problems using kotlin: Update project dependencies BrantApps/gradle-amazon-app-store-publisher#12

So, I still have dreams here.

• We may be able to remove the flavor and just use Play flavor as a separate issue since it doesn't seem to do anything different now (camera restriction was the only item? at least previously)
• Triple-T is interested in ingestion if possible: Amazon Appstore support Triple-T/gradle-play-publisher#583

I think the path forward is a fork to amazon app publisher in order to get it working again exactly as it was, then doing a PR to Triple-T to make it a publish mode there

[mikehardy]

Mmm - thought I had this one based off main so it shouldn't be flaking here after turning new reviewer off 🤔

com.ichi2.anki.ReviewerFragmentTest > testCustomSchedulerWithCustomData[emulator-5554 - 11] FAILED 
	java.lang.AssertionError:
	Expected: <3000>
ERROR   | Error while writing audio frame: [Success]