-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pitch data overhangs in freq domain #7
Comments
After the initial review of the original data sets my conclusion is that the dataset is really bad or at least the pitch values are. Every ending is indeed seen noted as falling down in pitch, even though such fall isn't audible in the recordings (not even those with the separated strings). This means that the dataset needs to have those endings cut manually or have all the pitch tracking redone with a better method, perhaps with the original penn? |
Some data seems to be missing, this is indeed missing as it is present in the audio. The next step is to write a program printing the original data labels over the STFT image. I don't see any other way than comparing what was there originally with what I got after preprocessing. Still analyzing |
Plot data as it is in the dataset, without any processing. Raw pitch data is plotted with plotly, next steps are midi and spectrogram. related to: #7
It could be possible to slighly help with deleting the unwanted values with plotly! |
This may also be helpful for learning more about the |
I was really hoping that midi would help with seeing where the proper parts of the node end, sadly that is not the case. This is what the plot looks like now: |
Introduce penn.convert.midi_to_frequency related to: #7
Another small break through. Resampling was obviously the issue! To get rid of unwanted fields in strange spots that were not in the original data it was enough to disable resampling for sampling rates that divide the GuitarSet native sampling rate of 44100 Hz without a remainder - that leaves the 11025, 22050 sampling rates without the need to resample. |
Sampling rates 11025 Hz and 22050 Hz are safe and do not need resampling. This simple fix gets rid of many ugly data points that were not present in the original data annotations. related to: #7
Had to cut the labels, probably around two from each string at the end to fit the audio data better. Really do not know why exactly. related to: #7
Had to cut the labels, probably around two from each string at the end to fit the audio data better. Really do not know why exactly. related to: #7
The jam track is separated into notes ordered by strings, each of those contains multiple pitches. related to: #7
remove_overhangs attempts to remove the overhangs from the last 20% of a note if they are below the average of the other 80% of the note. related to: #7
remove_overhangs attempts to remove the overhangs from the last 20% of a note if they are below the average of the other 80% of the note. related to: #7
And add new config options to enable and manipulate the overhangs removal: REMOVE_OVERHANGS - set True to enable the removal, REMOVE_OVERHANGS_DIVIDER - (int) set to manipulate the length of the overhang, REMOVE_OVERHANGS_THRESHOLD - (int) set the threshold in cents related to: #7
Just noticed that the data pitch labels are wrong. Many beginnings and endings of the pitch seem to overhang like in the picture below. This is totally unacceptable and very possibly the cause of the poor raw pitch accuracy of around 80%.
Fix that!
Check:
The text was updated successfully, but these errors were encountered: