Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New network design: 60 midi notes + offsets #9

Open
anthonio9 opened this issue Feb 16, 2024 · 3 comments
Open

New network design: 60 midi notes + offsets #9

anthonio9 opened this issue Feb 16, 2024 · 3 comments

Comments

@anthonio9
Copy link
Owner

anthonio9 commented Feb 16, 2024

This issue is about the introduction of a new network model, where the logits layer instead of 61440 pitch bins has 660*2 midi bins. Each of the 60 values in the first column corresponds to a separate midi note. The second column tells how big the pitch deviation is from that midi note, 0 being -50, 59 being +50 cents.

Conversion to this new format is done with penn.data.preprocess.core.note_dict_to_pitch_dict60() where 60 obviously stands for the number of midi notes.

anthonio9 added a commit that referenced this issue Feb 18, 2024
related to: #9
anthonio9 added a commit that referenced this issue Feb 18, 2024
related to: #9
anthonio9 added a commit that referenced this issue Feb 18, 2024
related to: #9
anthonio9 added a commit that referenced this issue Feb 18, 2024
related to: #9
anthonio9 added a commit that referenced this issue Feb 18, 2024
related to: #9
@anthonio9
Copy link
Owner Author

Well, the new config is almost ready for training, there are some problems left for tomorrow, like there's still no metrics or the offset is calculated on a cpu instead of the gpu. Fix it!

anthonio9 pushed a commit that referenced this issue Feb 19, 2024
anthonio9 added a commit that referenced this issue Feb 20, 2024
anthonio9 added a commit that referenced this issue Feb 20, 2024
anthonio9 added a commit that referenced this issue Feb 20, 2024
@anthonio9
Copy link
Owner Author

So far been trying to teach the network descrete midi notes, it seems to work rather well, so far the results are like below:

image

Seems like lower number of logits is not necessarily the same as better accuracy.

@anthonio9
Copy link
Owner Author

Take a look here to resolve the problem with images not being logged with wandb
wandb/wandb#1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant