Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate if we need to add back somthing like crdt-example.proto #164

Open
pjfanning opened this issue Aug 11, 2023 · 0 comments
Open
Assignees

Comments

@pjfanning
Copy link
Contributor

  • deleted in Delete crdt-example.proto #163 due to worries about it being of non-Lightbend provenance
  • the file was not directly used in any tests
  • @mdedetrich has suggested it is possible that the interop-tests have the file so that we will see if the code generation based on the proto file fails

@raboof would you have time to look at the history behind that file in akka-grpc? The akka-grpc PR is 877, one you wrote. I don't want to link directly to it because GitHub will update the akka-grpc if I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants