Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate why sample needs an extra implicit #49

Open
pjfanning opened this issue Mar 16, 2023 · 0 comments
Open

investigate why sample needs an extra implicit #49

pjfanning opened this issue Mar 16, 2023 · 0 comments

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Mar 16, 2023 •
edited
Loading

The sample was using a pretty old version of sbt-akka-grpc (0.8.4) and sbt-pekko-grpc is the equivalent of sbt-akka-grpc 2.1.6.

https://github.com/apache/incubator-pekko-samples/pull/12/files#diff-fe64fb9ec6ea3e1173f14f9d82f39712eaa40f3d0dc67d9cc54ec5cf91490465

Note that https://github.com/apache/incubator-pekko-samples/pull/12/files#diff-fe64fb9ec6ea3e1173f14f9d82f39712eaa40f3d0dc67d9cc54ec5cf91490465 needs ActorSystem as an implicit val to compile now.

Or we might need to update the docs to say why this is needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjfanning