[argo-events] - CRDS are not up to date

[ArieLevs]

Describe the bug

argo events helm chart version is not aligned with the CRDs,

for example chart version 2.4.1 has crds with version 1.7.0 https://github.com/argoproj/argo-helm/tree/argo-events-2.4.1/charts/argo-events/templates/crds
while should be 1.8.1 https://github.com/argoproj/argo-helm/blob/argo-events-2.4.1/charts/argo-events/Chart.yaml#L2

is there a "real" source of troth for the CRDs we can install them from?
the above issue raised since there is no jetstreamExotic definition anywhere, but its already part of the documentation.

Related helm chart

argo-events

Helm chart version

2.4.1

To Reproduce

install argo events chart version 2.4.1, app verion 1.8.1, the jetstreamExotic key is missing

Expected behavior

documentation / helm app version should match crds version

Screenshots

No response

Additional context

No response

[yu-croco]

is there a "real" source of troth for the CRDs we can install them from?

We follow upstreams' CRD. In Argo Event's case, we follow below.
https://github.com/argoproj/argo-events/tree/v1.8.1/manifests/base/crds

It looks CRD is not changed for a few years in upstream... 🤔

[yu-croco]

@ArieLevs

the above issue raised since there is no jetstreamExotic definition anywhere, but its already part of the documentation.

Do you get any errors when you deploy the resources in k8s ?

Upstream's CRD defines just spec as type object (argo-helm as well), so I wonder it will work well without the jetstreamExotic definition in CRD. 🤔

[ArieLevs]

@yu-croco yes, error returned:

admission webhook "webhook.argo-events.argoproj.io" denied the request: invalid spec: either "nats", "jetstream", or "kafka" needs to be specified

I'm using the manifest from this example

[yu-croco]

@ArieLevs
Thank you for the info.
Since we are following the upsteam's CRD, so I wonder it's better to ask in upsteam... 🤔

@pdrastil @jmeridth @tico24
Do you have any ideas about this...? 🤔

[jmeridth]

@ArieLevs This feature was added to the code 2 weeks ago with argoproj/argo-events#2878. Release 1.8.1 was released before that. The docs are showing features available to master. You can see this by the ValidateEventBus.go that has jetstreamExotic now here.

Once argo-events does a new release, we will also release a new chart.

You may want to ping the argo-events folks in CNCF slack #argo-events about when a new release is expected. Cheers.

[jmeridth]

I have filed an upstream issue in argo-workflows for showing/allowing selections of versioned docs here. We need to do the same with argo-events.

[ArieLevs]

great! thanks a lot @yu-croco and @jmeridth 🚀

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[yu-croco]

Hi @ArieLevs ,
This PR ( #2417 ) will resolve this issue. 🚀
jetstreamExotic is added In appVersion v1.9.0 ( argoproj/argo-events@v1.8.1...v1.9.0 ).