Incorrect default resync period

[huikang]

The default DefaultRolloutResyncPeriod is 900 second. However, the log of the rollout-controller with default setting shows that the resync period is 5min (300 second), which is different than the default. Is there anything wrong with the controller?

INFO[2021-05-04T14:40:57-04:00] Started syncing rollout                       generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary
INFO[2021-05-04T14:40:57-04:00] No StableRS exists to reconcile or matches newRS  namespace=default rollout=rollouts-demo-canary
INFO[2021-05-04T14:40:57-04:00] No Steps remain in the canary steps           namespace=default rollout=rollouts-demo-canary
INFO[2021-05-04T14:40:57-04:00] No status changes. Skipping patch             generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary
INFO[2021-05-04T14:40:57-04:00] Reconciliation completed                      generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary time_ms=0.770942

INFO[2021-05-04T14:45:57-04:00] Started syncing rollout                       generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary
INFO[2021-05-04T14:45:57-04:00] No StableRS exists to reconcile or matches newRS  namespace=default rollout=rollouts-demo-canary
INFO[2021-05-04T14:45:57-04:00] No Steps remain in the canary steps           namespace=default rollout=rollouts-demo-canary
INFO[2021-05-04T14:45:57-04:00] No status changes. Skipping patch             generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary
INFO[2021-05-04T14:45:57-04:00] Reconciliation completed                      generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary time_ms=2.469787


INFO[2021-05-04T14:50:57-04:00] Started syncing rollout                       generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary
INFO[2021-05-04T14:50:57-04:00] No StableRS exists to reconcile or matches newRS  namespace=default rollout=rollouts-demo-canary
INFO[2021-05-04T14:50:57-04:00] No Steps remain in the canary steps           namespace=default rollout=rollouts-demo-canary
INFO[2021-05-04T14:50:57-04:00] No status changes. Skipping patch             generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary
INFO[2021-05-04T14:50:57-04:00] Reconciliation completed                      generation=1 namespace=default resourceVersion=1375 rollout=rollouts-demo-canary 

[huikang]

I guess this is the time a rollout obj pushed to the queue.

[jessesuen]

Interesting... 900s is the maximum, but it does get short-circuited by other factors (e.g. if the rollout ReplicaSet changed), then the rollout might also get requeued. I believe we do log when rollout becomes requeued.