Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for Windows build #5189

Closed
aldenml opened this issue Sep 26, 2020 · 8 comments
Closed

Use GitHub Actions for Windows build #5189

aldenml opened this issue Sep 26, 2020 · 8 comments
Labels

Comments

@aldenml
Copy link
Contributor

aldenml commented Sep 26, 2020

libtorrent branch: master
platform: windows

Appveyor is just too slow because its a single job at a time. GitHub Actions should improve the waiting time of PR merges.

@arvidn
Copy link
Owner

arvidn commented Sep 26, 2020

yes, it seems github actions could be quite helpful. I think travis supports windows these days too. It just takes a lot of time to get a new environment set up (at least to fully replace all the things appveyor does today).

@FranciscoPombal
Copy link
Contributor

FranciscoPombal commented Sep 26, 2020

@arvidn

I don't know about the rest, but if all you're doing with CMake in Appveyor is just the the build, I can contribute something like what I recently did for qBIttorrent: https://github.com/qbittorrent/qBittorrent/blob/2bfaa8229a8f3ed00eabaf60f7039c7be4d4de25/.github/workflows/ci.yaml#L83. It's easy with vcpkg. The rest (b2 builds and test runs) could be added later.

The results have been quite good so far: https://github.com/qbittorrent/qBittorrent/actions. Apart from the very first run which was of course uncached, all Windows builds tend to finish in under 15 minutes, with the occasional excursion a bit over that, and the very infrequent excursion up to 30-40 minutes. All of this while multiple builds can run at the same time easily. In contrast, sometimes I've waited 6+ hours for libtorrent builds on Appveyor to even start.

@arvidn
Copy link
Owner

arvidn commented Sep 26, 2020

please do!

@vktr
Copy link
Contributor

vktr commented Oct 2, 2020

@FranciscoPombal are you looking at this? I might make a try otherwise - I did the same for PicoTorrent the other day much based on the suggestion from this thread :)

@FranciscoPombal
Copy link
Contributor

@vktr Yeah I should be able to post something either to day or during the weekend, got a bit delayed, sorry about that.

@vktr
Copy link
Contributor

vktr commented Oct 2, 2020

Awesome :) No stress from me, just didn't want to start anything that is being looked at

@FranciscoPombal
Copy link
Contributor

#5197

@stale
Copy link

stale bot commented Jan 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 19, 2021
@stale stale bot closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants