Magical disapearing Errors

[elassadi]

I want to point to a kind of smell in the Code in Avo I would love to get ride of it :
here is an example:

   def authorize(user, record, action, policy_class: nil, **args)
       return true if skip_authorization
       return true if user.nil?

       client.authorize user, record, action, policy_class: policy_class

       true
     rescue NoPolicyError => error
       # By default, Avo allows anything if you don't have a policy present.
       return true unless Avo.configuration.raise_error_on_missing_policy

       raise error
     rescue => error
       if args[:raise_exception] == false
         false
       else
         raise error
       end
     end

I have a problem with a rescue block without any error specified,
we ran into similar problems in other projects, and it's a nightmare hunting down magical disappearing exceptions.

We Should avoid usage of rescue blocks in General and especially without a specific error i the case above it could be changed to something like

   def authorize(user, record, action, policy_class: nil, **args)
       return true if skip_authorization
       return true if user.nil?

       client.authorize user, record, action, policy_class: policy_class

       true
     rescue NoPolicyError => error
       # By default, Avo allows anything if you don't have a policy present.
       return true unless Avo.configuration.raise_error_on_missing_policy

       raise error
     rescue Avo::NoAccessError => error
       if args[:raise_exception] == false
         false
       else
         raise error
       end
     end

[adrianthedev]

So, you're saying you actually ran into this issue? Swallowing the errors. That should not happen, and AFAIC it should only happen with authorization errors.

Please give me an example where errors (not authorization) are being swallowed there.

[elassadi]

its very simple if you have a simple authorization adapter like this one

class Adapater 
  def authorize 
    do_some_internal_checks?
   end
   
   def do_some_internal_checks?
     # any exception that happend here will be rescued 
     
     nil.to_s
   end
 end