Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amplify_analytics_pinpoint_dart] Upgrade drift dependency. #5323

Open
asaarnak opened this issue Aug 21, 2024 · 16 comments
Open

[amplify_analytics_pinpoint_dart] Upgrade drift dependency. #5323

asaarnak opened this issue Aug 21, 2024 · 16 comments
Labels
analytics Issues related to the Amplify Analytics Category dependencies Pull requests that update a dependency file question A question about the Amplify Flutter libraries

Comments

@asaarnak
Copy link
Contributor

asaarnak commented Aug 21, 2024

Increase drift from ^2.18.0 to ^2.20.0

Because no versions of amplify_auth_cognito match >2.4.0 <3.0.0 and amplify_auth_cognito 2.4.0 depends on amplify_analytics_pinpoint_dart ^0.4.4, amplify_auth_cognito ^2.4.0 requires amplify_analytics_pinpoint_dart ^0.4.4.
Because amplify_analytics_pinpoint_dart 0.4.4 depends on drift >=2.18.0 <2.19.0 and no versions of amplify_analytics_pinpoint_dart match >0.4.4 <0.5.0, amplify_analytics_pinpoint_dart ^0.4.4 requires drift >=2.18.0 <2.19.0.
Thus, amplify_auth_cognito ^2.4.0 requires drift >=2.18.0 <2.19.0.
So, because my_app depends on both amplify_auth_cognito ^2.4.0 and drift ^2.20.0, version solving failed.
@NikaHsn
Copy link
Member

NikaHsn commented Aug 21, 2024

@asaarnak thank you for submitting this request. We will take a look and get back to you with any updates.

@NikaHsn NikaHsn added analytics Issues related to the Amplify Analytics Category question A question about the Amplify Flutter libraries labels Aug 21, 2024
@dkliss
Copy link

dkliss commented Aug 22, 2024

Hi, I also have same problem, i think because with latest flutter web now needs min web 1.0.0 and drift over 2.20.

Because no versions of amplify_auth_cognito match >2.4.0 <3.0.0 and amplify_auth_cognito 2.4.0 depends on amplify_analytics_pinpoint_dart ^0.4.4, amplify_auth_cognito ^2.4.0 requires amplify_analytics_pinpoint_dart ^0.4.4.
Because amplify_analytics_pinpoint_dart 0.4.4 depends on drift >=2.18.0 <2.19.0 and no versions of amplify_analytics_pinpoint_dart match >0.4.4 <0.5.0, amplify_analytics_pinpoint_dart ^0.4.4 requires drift >=2.18.0 <2.19.0.
Thus, amplify_auth_cognito ^2.4.0 requires drift >=2.18.0 <2.19.0.
Because drift 2.18.0 depends on web ^0.5.0 and no versions of drift match >2.18.0 <2.19.0, drift >=2.18.0 <2.19.0 requires web ^0.5.0.
Thus, amplify_auth_cognito ^2.4.0 requires web ^0.5.0.
So, because my_app depends on both amplify_auth_cognito ^2.4.0 and web ^1.0.0, version solving failed.

@NikaHsn
Copy link
Member

NikaHsn commented Aug 22, 2024

@dkliss thanks for prviding this info. we will look into this and will provide update as we have them.

@ma-vai
Copy link

ma-vai commented Sep 5, 2024

Hello, adding that we are also experiencing the same issue. Here is one example of several packages we cannot update due to the same constraint. Bumping the version would be greatly appreciated.

Because no versions of amplify_auth_cognito match >2.4.1 <3.0.0 and amplify_auth_cognito 2.4.1 depends on amplify_analytics_pinpoint_dart ^0.4.5, amplify_auth_cognito ^2.4.1 requires amplify_analytics_pinpoint_dart ^0.4.5. And because no versions of amplify_analytics_pinpoint_dart match >0.4.5 <0.5.0 and amplify_analytics_pinpoint_dart 0.4.5 depends on drift >=2.18.0 <2.19.0, amplify_auth_cognito ^2.4.1 requires drift >=2.18.0 <2.19.0. Because drift 2.18.0 depends on web ^0.5.0 and no versions of drift match >2.18.0 <2.19.0, drift >=2.18.0 <2.19.0 requires web ^0.5.0. Thus, amplify_auth_cognito ^2.4.1 requires web ^0.5.0. And because flutter_webrtc >=0.11.7 depends on web ^1.0.0, amplify_auth_cognito ^2.4.1 is incompatible with flutter_webrtc >=0.11.7. So, because verseai_flutter_client depends on both amplify_auth_cognito ^2.4.1 and flutter_webrtc ^0.11.7, version solving failed.

@github-actions github-actions bot added the pending-maintainer-response Pending response from a maintainer of this repository label Sep 5, 2024
@NikaHsn
Copy link
Member

NikaHsn commented Sep 5, 2024

would you be able to override the drift version in your pubspec_overrides.yaml to use the latest version?
we need to upgrade other dependecies e.g. pigeon, to major versions, in order to upgrade the drift version. this will take some time, we'll keep you updated here.

@github-actions github-actions bot removed the pending-maintainer-response Pending response from a maintainer of this repository label Sep 5, 2024
@dkliss
Copy link

dkliss commented Sep 16, 2024

drift

Thanks for this suggestion. Below is what worked for me, in case it helps, still waiting for a fix though:

dependencies:
  amplify_flutter: ^2.4.1
  amplify_auth_cognito: ^2.4.1
  drift: ^2.18.0
sqlite3: 
dependency_overrides:
  sqlite3: ^2.4.3
  drift: ^2.20.2

@github-actions github-actions bot added the pending-maintainer-response Pending response from a maintainer of this repository label Sep 16, 2024
@Equartey Equartey added dependencies Pull requests that update a dependency file and removed pending-maintainer-response Pending response from a maintainer of this repository labels Sep 16, 2024
@simolus3
Copy link

simolus3 commented Oct 1, 2024

Is there a reason for the upper version bound on the drift dependency? Me messing up semantic versioning? If so, apologies! If not, are you using internal APIs or is there something I can do to help remove the upper bound and enable you to support all ^2.18.0 drift releases?

@github-actions github-actions bot added the pending-maintainer-response Pending response from a maintainer of this repository label Oct 1, 2024
@Equartey
Copy link
Contributor

Equartey commented Oct 4, 2024

Hello @simolus3, it's common practice for us to include an upper bound on community dependencies to safeguard the user experience from any potential issues caused by new versions. Some package maintainers don't adhere to SemVer, so breaking changes can sneak into minor/patch versions.

If not, are you using internal APIs or is there something I can do to help remove the upper bound and enable you to support all ^2.18.0 drift releases?

We appreciate the excitement to get this resolved, truly. With this Drift update in particular we have at lease one transitive dependency update that contains breaking changes. This requires extra effort and care to ensure nothing is broken during the update. Like mentioned above, we're working to get this resolved and will update y'all here when we can.

@github-actions github-actions bot removed the pending-maintainer-response Pending response from a maintainer of this repository label Oct 4, 2024
@jamilsaadeh97
Copy link
Contributor

I'm also blocked by this because I'm using firebase_core and crashlytics.

Currently there's a bug keeping apps from getting built on older versions of those packages and many other popular packages using Xcode 16 and the "workaround" is not recommended at all.

The issue is resolved in the new version but more and more packages require web: ^1.0.0 and drift is keeping us from updating.

@github-actions github-actions bot added the pending-maintainer-response Pending response from a maintainer of this repository label Oct 6, 2024
@NikaHsn
Copy link
Member

NikaHsn commented Oct 14, 2024

@jamilsaadeh97 sorry that you are facing this issue. you may override the dependecies for now as mentioned above.
we are working to resolve this and we will provide update here as we have them.

@github-actions github-actions bot removed the pending-maintainer-response Pending response from a maintainer of this repository label Oct 14, 2024
@nikorehnback
Copy link

@dkliss have you encountered any issues when using dependency override, everything working fine?

@github-actions github-actions bot added the pending-maintainer-response Pending response from a maintainer of this repository label Oct 28, 2024
@dkliss
Copy link

dkliss commented Oct 28, 2024

@dkliss have you encountered any issues when using dependency override, everything working fine?

Yes, have everything is working fine. Have not experienced any issues.

@asaarnak
Copy link
Contributor Author

We are waiting for amplify to update drift version.
drift: ^2.21.0 is now out

@ekjotmultani ekjotmultani removed the pending-maintainer-response Pending response from a maintainer of this repository label Oct 28, 2024
@harmeet-sidhu
Copy link

@dkliss have you encountered any issues when using dependency override, everything working fine?

Yes, have everything is working fine. Have not experienced any issues.

I am unable to build the app after dependency override. I am getting the following error:

../../.pub-cache/hosted/pub.dev/amplify_storage_s3_dart-0.4.6/lib/src/storage_s3_service/transfer/database/tables.drift.dart:281:53: Error: Expected 10 type arguments.
class $$TransferRecordsTableTableManager extends i0.RootTableManager<
                                                    ^^^^^^^^^^^^^^^^
../../.pub-cache/hosted/pub.dev/amplify_storage_s3_dart-0.4.6/lib/src/storage_s3_service/transfer/database/tables.drift.dart:329:16: Error: Expected 10 type arguments.
    extends i0.ProcessedTableManager<
               ^^^^^^^^^^^^^^^^^^^^^
../../.pub-cache/hosted/pub.dev/amplify_storage_s3_dart-0.4.6/lib/src/storage_s3_service/transfer/database/tables.drift.dart:299:11: Error: No named parameter with the name 'getChildManagerBuilder'.
          getChildManagerBuilder: (p) =>
          ^^^^^^^^^^^^^^^^^^^^^^
../../.pub-cache/hosted/pub.dev/drift-2.20.2/lib/src/runtime/manager/manager.dart:150:3: Context: Found this candidate, but the arguments don't match.
  TableManagerState(
  ^^^^^^^^^^^^^^^^^
../../.pub-cache/hosted/pub.dev/amplify_storage_s3_dart-0.4.6/lib/src/storage_s3_service/transfer/database/tables.drift.dart:292:14: Error: Too many positional arguments: 0 allowed, but 1 found.
Try removing the extra positional arguments.
      : super(i0.TableManagerState(
             ^
../../.pub-cache/hosted/pub.dev/amplify_storage_s3_dart-0.4.6/lib/src/storage_s3_service/transfer/database/tables.drift.dart:338:3: Error: The superclass, 'i0.ProcessedTableManager<i0.GeneratedDatabase, i1.$TransferRecordsTable, i1.TransferRecord, i1.$$TransferRecordsTableFilterComposer, i1.$$TransferRecordsTableOrderingComposer, $$TransferRecordsTableProcessedTableManager, $$TransferRecordsTableInsertCompanionBuilder, $$TransferRecordsTableUpdateCompanionBuilder>', has no unnamed constructor that takes no arguments.
  $$TransferRecordsTableProcessedTableManager(super.$state);
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Target kernel_snapshot_program failed: Exception


FAILURE: Build failed with an exception.

@github-actions github-actions bot added the pending-maintainer-response Pending response from a maintainer of this repository label Nov 7, 2024
@tyllark tyllark removed the pending-maintainer-response Pending response from a maintainer of this repository label Nov 7, 2024
@tetsujp84
Copy link

Hi there, I’m just checking in to see if there’s been any recent progress on this issue. Are there any updates or next steps you could share?
I’m still experiencing this problem and haven’t been able to upgrade to Xcode 16 because of it. Any information would be greatly appreciated. Thanks!

@github-actions github-actions bot added the pending-maintainer-response Pending response from a maintainer of this repository label Dec 11, 2024
@tyllark
Copy link
Member

tyllark commented Dec 11, 2024

Hi @tetsujp84, I've been working on this issue as time permits, but the changes have been pretty involved. I've updated our Flutter version, dart sdk, and several packages alongside Drift. The main task remaining is fixing all of the native breaking changes. Thank you for being patient while we clean up this technical debt and we will post here once we finalize the fix!

@github-actions github-actions bot removed the pending-maintainer-response Pending response from a maintainer of this repository label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics Issues related to the Amplify Analytics Category dependencies Pull requests that update a dependency file question A question about the Amplify Flutter libraries
Projects
None yet
Development

No branches or pull requests