Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: local invoke add option to chose container port #6348

Closed
gastonsilva opened this issue Nov 27, 2023 · 1 comment
Closed

Feature request: local invoke add option to chose container port #6348

gastonsilva opened this issue Nov 27, 2023 · 1 comment
Labels
stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request

Comments

@gastonsilva
Copy link

Describe your idea/feature/enhancement

local invoke should allow to chose RAPID_PORT_CONTAINER other than 8080 at least when running with --docker-network host
There is no way to change this port as it is a hardcoded value

Proposal

Add a parameter to allow changing this value:

aws-sam-cli/samcli/local/docker/container.py

Line 59 in 05bc6bc

RAPID_PORT_CONTAINER = "8080"

Additional Details

Closes #6347
@gastonsilva gastonsilva added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels Nov 27, 2023
@gastonsilva gastonsilva changed the title Feature request: TITLE Feature request: local invoke add option to chose container port Nov 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gastonsilva