Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Support for renaming methods coming from type inclusions #38481

Closed
pubudu91 opened this issue Oct 31, 2022 · 2 comments
Closed
Assignees
Labels
Area/Rename Language Server Rename related issues IceBox Older issues that are not being actively worked on but may be revisited in the future. Points/4 Equivalent to four day effort Priority/Low Team/LanguageServer Language Server Implementation related issues. #Compiler Type/NewFeature

Comments

@pubudu91
Copy link
Contributor

Description

This is more of a suggestion. Need to consider and see if what I'm proposing is feasible/makes sense from a language semantics POV. Consider the following:

type Foo object {
    function foo(); // <1>
};

class Bar {
    *Foo;

    function foo() {} // <2>
}

Currently when we rename foo() method at either <1> or <2>, it only renames that particular case (along with its usages I presume). Suppose we rename foo to bar at <1>. Then this breaks all the places in the code where we have used Foo as a type inclusion. So can we consider or rather is it correct to consider foo() at <2> a reference of foo() at <1> and rename foo to bar at <2> as well? The inverse shouldn't happen though: renaming foo() at <2> to bar() shouldn't change foo() at <1>.

Describe your problem(s)

No response

Describe your solution(s)

No response

Related area

-> Editor

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@pubudu91 pubudu91 added Type/NewFeature Team/LanguageServer Language Server Implementation related issues. #Compiler Area/Rename Language Server Rename related issues labels Oct 31, 2022
@malinthar malinthar added the Points/4 Equivalent to four day effort label Nov 3, 2022
@sanjana sanjana moved this from Todo to In Progress in Ballerina Team Main Board Nov 17, 2022
@sanjana sanjana moved this from BackLog to In Progress in Ballerina Team Main Board Nov 23, 2022
@sanjana sanjana moved this from In Progress to BackLog in Ballerina Team Main Board Nov 25, 2022
@sanjana sanjana moved this from BackLog to On Hold in Ballerina Team Main Board Nov 25, 2022
@sanjana
Copy link
Contributor

sanjana commented Nov 25, 2022

Awaiting changes from #34319

@anupama-pathirage anupama-pathirage added the IceBox Older issues that are not being actively worked on but may be revisited in the future. label Nov 20, 2024
@anupama-pathirage
Copy link
Contributor

We are closing this issue due to inactivity. If you need further assistance or have additional input, feel free to reopen it. Thank you for helping us maintain a relevant and focused issue list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Rename Language Server Rename related issues IceBox Older issues that are not being actively worked on but may be revisited in the future. Points/4 Equivalent to four day effort Priority/Low Team/LanguageServer Language Server Implementation related issues. #Compiler Type/NewFeature
Projects
None yet
Development

No branches or pull requests

5 participants