Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Remove typedesc class create for records #41851

Closed
chiranSachintha opened this issue Dec 9, 2023 · 2 comments
Closed

[Task]: Remove typedesc class create for records #41851

chiranSachintha opened this issue Dec 9, 2023 · 2 comments
Assignees
Labels
Reason/Invalid Issue is invalid. Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Task

Comments

@chiranSachintha
Copy link
Member

Description

In the earlier implementation includes a typedesc class for storing default values of record fields. This was initially necessary to retain default values within the typedesc. However, with the recent work to creating closures for record defaults, the typedesc class is no longer required and can be safely removed.

Describe your task(s)

No response

Related area

-> Runtime

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@chiranSachintha chiranSachintha self-assigned this Dec 9, 2023
@chiranSachintha chiranSachintha added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Points/1.5 Equivalent to one and a half day effort labels Dec 9, 2023
@dulajdilshan dulajdilshan moved this from PR Sent to Planned for Sprint in Ballerina Team Main Board Feb 28, 2024
@chiranSachintha chiranSachintha moved this from Planned for Sprint to In Progress in Ballerina Team Main Board Mar 13, 2024
@dulajdilshan dulajdilshan removed the Points/1.5 Equivalent to one and a half day effort label Mar 13, 2024
@chiranSachintha chiranSachintha moved this from In Progress to Planned for Sprint in Ballerina Team Main Board Mar 21, 2024
@chiranSachintha chiranSachintha moved this from Planned for Sprint to In Progress in Ballerina Team Main Board May 22, 2024
@dulajdilshan dulajdilshan moved this from In Progress to Planned for Sprint in Ballerina Team Main Board Jun 12, 2024
@chiranSachintha chiranSachintha moved this from Planned for Sprint to In Progress in Ballerina Team Main Board Jun 13, 2024
@dulajdilshan dulajdilshan moved this from In Progress to Planned for Sprint in Ballerina Team Main Board Jun 19, 2024
@chiranSachintha chiranSachintha moved this from Planned for Sprint to In Progress in Ballerina Team Main Board Jul 3, 2024
@chiranSachintha chiranSachintha moved this from In Progress to Planned for Sprint in Ballerina Team Main Board Jul 14, 2024
@rdulmina rdulmina assigned rdulmina and unassigned chiranSachintha Aug 6, 2024
@rdulmina
Copy link
Contributor

if we remove the typedesc class we need to find a way to preserve the value class for the corresponding typedesc. Hence we decided to keep the class as it is

@github-project-automation github-project-automation bot moved this from In Progress to Done in Ballerina Team Main Board Aug 22, 2024
@rdulmina
Copy link
Contributor

rdulmina commented Aug 22, 2024

typedesc class handles the instantiation of the corresponding generated value class for the type.

Screenshot 2024-08-22 at 15 39 15

@rdulmina rdulmina added the Reason/Invalid Issue is invalid. label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reason/Invalid Issue is invalid. Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Task
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants