Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Project API load() method is not correctly resolving dependencies #41866

Closed
niveathika opened this issue Dec 11, 2023 · 3 comments · Fixed by #41904
Closed

[Bug]: Project API load() method is not correctly resolving dependencies #41866

niveathika opened this issue Dec 11, 2023 · 3 comments · Fixed by #41904
Assignees
Labels
Area/ProjectAPI Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Type/Bug
Milestone

Comments

@niveathika
Copy link
Contributor

Description

SQL testcase failing to resolve dependency time module

https://github.com/ballerina-platform/ballerina-lang/actions/runs/7170430688/job/19523715953

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@niveathika
Copy link
Contributor Author

Here the resolution happens sucessfully after the first attempt.

https://github.com/ballerina-platform/ballerina-lang/actions/runs/7172073878/job/19541598996?pr=41867

This is after disabling one test. Another is failing

@ShammiL
Copy link
Contributor

ShammiL commented Dec 15, 2023

This failure in resolving the time module, which is a dependency of the sql module, is due to the time module not been detected when creating the dependencyGraph.

Further investigating revealed that the time module is not added to the dependency-graph.json of ballerina/sql:1.11.2 pack as the scope of the time module dependency is taken as TEST_ONLY during the dependency resolution test.

Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@azinneera azinneera added this to the 2201.8.4 milestone Mar 8, 2024
@gayaldassanayake gayaldassanayake added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/ProjectAPI Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants