-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some of the Java classes in module-io
proper utility classes
#4901
Closed
vil02 opened this issue
Oct 10, 2023
· 0 comments
· Fixed by ballerina-platform/module-ballerina-io#1096
Closed
Make some of the Java classes in module-io
proper utility classes
#4901
vil02 opened this issue
Oct 10, 2023
· 0 comments
· Fixed by ballerina-platform/module-ballerina-io#1096
Comments
This was referenced Oct 10, 2023
This was referenced Oct 17, 2023
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Some of the Java classes in
io
module, namely:TestUtil
,IOConstants
,PropertyUtils
,WriteXml
,CsvChannelUtils
,appear to be utility classes (i.e. all of the members and methods are
static
). Generally speaking it is a good practice to:private
(like inModuleUtils
) - because it does not make sense to have objects of such classes,final
- because it does not make sense to derive any class from them.There are benefits of doing this:
Suggested Labels:
module/io,hacktoberfest
Suggested Assignees:
@vil02
Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:
#4894
The text was updated successfully, but these errors were encountered: