Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance tests aren't running all cases #31

Open
toptensoftware opened this issue Aug 6, 2019 · 0 comments
Open

Conformance tests aren't running all cases #31

toptensoftware opened this issue Aug 6, 2019 · 0 comments

Comments

@toptensoftware
Copy link

The conformance tests aren't running all the test cases. The bit mask in BidiTest.txt data is a mask of up to 3 different runs that should be made whereas the test cases are only running one case.

In ./test/conform/bidiclass/runner.js, instead of

    const bitset = test.bitset;
    const paragraphLevel = ((bitset & 2) > 0) ? 0 : 1;
    const autoLTR = ((bitset & 1) > 0) ? true : false;

it should be something like this:

    for (let bit = 1; bit < 8; bit = bit << 1)
    {
      if ((test.bitset & bit) == 0)
        continue;

      const paragraphLevel = ((bit & 2) > 0) ? 0 : 1;
      const autoLTR = ((bit & 1) > 0) ? true : false;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant