Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EValueEstimator accept a Generator #703

Open
padix-key opened this issue Nov 15, 2024 · 0 comments
Open

Make EValueEstimator accept a Generator #703

padix-key opened this issue Nov 15, 2024 · 0 comments
Labels
major release Potentially backwards incompatible changes that should go in to the next major release

Comments

@padix-key
Copy link
Member

Currently the only way to ensure reproducible results of the EValueEstimator is calling np.random.seed() before creating it. However, this np.random.xxx API is deprecated and superseded by using an explicit Generator.

To reflect this change in numpy, EValueEstimator should accept a Generator to ensure reproducibility.
@padix-key padix-key added the major release Potentially backwards incompatible changes that should go in to the next major release label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major release Potentially backwards incompatible changes that should go in to the next major release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@padix-key