Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int overflow in void HierarchicalSNE<scalar_type, sparse_scalar_matrix_type>::initializeFirstScale() for large data #28

Open
thoellt opened this issue Jul 7, 2021 · 0 comments · May be fixed by #36

Comments

@thoellt
Copy link
Member

thoellt commented Jul 7, 2021

In void HierarchicalSNE<scalar_type, sparse_scalar_matrix_type>::initializeFirstScale() there is the danger of an integer overlow in the for loop .

int idx = i * nn + n; will overflow for moderately large data (> ~25M points, perplexity 30).

Even unsigned will be rather limited. It should be considered to also move to 64bit indices wherever indexing into data structures with multiple values per datapoint.

@alxvth alxvth linked a pull request Apr 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant