Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction list pagination is active even when there is nothing to paginate #10

Open
cryptonoob42 opened this issue Jun 22, 2019 · 1 comment

Comments

@cryptonoob42
Copy link

Given an address with less than 10 transactions, the "+10" button is active nonetheless. It can be clicked deliberately often, leading to pages with "10", "20", etc. in the middle, but no transactions, for obvious reasons.

Suggestion: the "+10" button should only be active if more than 10 transactions exist for the given address.

@EggPool
Copy link
Contributor

EggPool commented Jun 23, 2019

Yeah.
The current wallet server api does not tell how many addresses there are.
First call returns the latest 10.
From there, we could know there are less than 10, in that case hide the button.
But if there are 10, no way to know if there are only 10, 20 or 2000.

An extra data could give tx count as part of balance for instance, at the expanse of a significant query.
Would need some api change.

In the mean time, at least not showing the next button if there are less than 10 txns in the current page would mitigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants