[BUG]: Unable to run Custom Nodes / Impact Pack

[dupuisj]

Hello,
We have a workflow using the following custom nodes that we want to run in serverless mode on Runpod.

    "https://github.com/ltdrdata/ComfyUI-Impact-Pack": {
        "hash": "c9b3aecd1af14f39b2dd311f096a24dbea18d5aa",
        "disabled": false
    },
    "https://github.com/cubiq/ComfyUI_essentials": {
        "hash": "5a4e5cd5750515d76f3a3363b7d2a0f362507796",
        "disabled": false
    },
    "https://github.com/vuongminh1907/ComfyUI_ZenID": {
        "hash": "9590d4bf18289fe7927d56a18bf23041c03b7c98",
        "disabled": false
    },
    "https://github.com/cubiq/ComfyUI_InstantID": {
        "hash": "1ef34ef573581bd9727c1e0ac05aa956b356a510",
        "disabled": false
    },
    "https://github.com/cubiq/ComfyUI_IPAdapter_plus": {
        "hash": "b188a6cb39b512a9c6da7235b880af42c78ccd0d",
        "disabled": false
    }

What we did:

• We've been forking the repo,
• As we're using a network volume storage, we commented all lines related to model downloading
• were able to create a new image from your repo
• We successfully deployed an image in serverless on runpod and it was succesfully getting request, with a custom model from the server storage

Now, we've been trying to install the custom nodes:

• we just added the complete snapshot.json that we had exported from our local ComfyUI
• But we ran into so many errors that we wanted to isolate 2 custom nodes to start with
• so we kept Impact Pack and ComfyEssentials in the snapshot json
• We are able to build an image
• But when running we're getting the following errors

5 items
"endpointId":"hgpaopqr440ej2"
"workerId":"fcy04t99tzik65"
"level":"info"
"message":"invalid prompt: {'type': 'invalid_prompt', 'message': 'Cannot execute because node UltralyticsDetectorProvider does not exist.', 'details': "Node ID '#761'", 'extra_info': {}}\n"
"dt":"2024-12-05 18:26:46.09510720"
}

{5 items
"endpointId":"hgpaopqr440ej2"
"workerId":"fcy04t99tzik65"
"level":"info"
"message":" 0.1 seconds (IMPORT FAILED): /comfyui/custom_nodes/ComfyUI-Impact-Pack\n"
"dt":"2024-12-05 18:26:46.09483904"

{5 items
"endpointId":"hgpaopqr440ej2"
"workerId":"fcy04t99tzik65"
"level":"info"
"message":"[Impact Pack] Failed to import due to several dependencies are missing!!!!\n"
"dt":"2024-12-05 18:26:46.09432608"
}

I feel like we're missing a step somewhere. By the way, it's a pretty long process to make 1 test, what's the best process to test maybe locally and debug? As we have many other nodes that we'd like to install we need a better process.

IDEA : We've been using for some time [this repo used to work on Replicate](https://github.com/fofr/cog-comfyui/), 
It's nice because it comes with several models installed and famous custom nodes
-- as custom models are easy to setup on Runpod, it would maybe be interesting to get a working process to help people create their own image with all those custom nodes successfully on RunPod with a ready to use working snapshot.json export.

I've noted that they're running a [special script to install custom nodes ](https://github.com/fofr/cog-comfyui/blob/main/scripts/install_custom_nodes.py)succesfully.

And that they had to fork some repo  ([](https://github.com/fofr/cog-comfyui/blob/main/custom_nodes.json))
    "repo": "https://github.com/fofr/ComfyUI-Impact-Pack",
    "commit": "9ad8f85",
    "notes": "Fork of https://github.com/ltdrdata/ComfyUI-Impact-Pack which prevents automatic installation of dependencies"
  },

Sorry for the long message and thanks for all your work

[hlktrkn]

ltdrdata/ComfyUI-Impact-Pack#843

Have you happened to see this? Crypto miners have compromised the Ultralitycs repo and there's an incident still ongoing

[geecrane]

I'm new to Comfyui but maybe some nodes require the latest Comfyui to be installed. AFAIK, the comfyui version installed (see Dockerfile) is not the latest. Hope this helps

[jayjake0]

I'm new to Comfyui but maybe some nodes require the latest Comfyui to be installed. AFAIK, the comfyui version installed (see Dockerfile) is not the latest. Hope this helps

IMO it is not a bug.

It is a worker, so I guess you need to build a new docker image with the latest ComfyUI version first and use that build in RunPod. Of course if it is the case. ""message":"[Impact Pack] Failed to import due to several dependencies are missing!!!!\n" means you need to include all those dependencies in worker's docker build. Other option may be installation of a custom node that correspond to a version of ComfyUI that is in docker build you use - I guess you can check it in requirements.txt file of the repo. I think makeing a new working docker build with the latest ComfyUI would work better and may be easier to do. This is the thing I guess: https://github.com/blib-la/runpod-worker-comfy?tab=readme-ov-file#custom-docker-image. Imapact nodes developer mentioned that "V7.6: Automatic installation is no longer supported. Please install using ComfyUI-Manager, or manually install requirements.txt and run install.py to complete the installation." so I guess custom docker image with the worker is needed anyway.

[dupuisj]

I understand, but I feel like the repo is not currently optimized to install a large number of custom nodes in a reliable way.

The technic using the snapshot file is promising but contrary to The repo I mention, it is not mentioning a specific version of each custom node meaning it will remain unstable.

We are working on an hybrid technic using this script to install custom nodes, we’ll let you know if that works

[jayjake0]

I understand, but I feel like the repo is not currently optimized to install a large number of custom nodes in a reliable way.

You can make your docker image. There are so many comfyui nodes that satisfying those dependencies and requirements in one build are rather impossible.