-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still does not annotate directive.controller #77
Comments
I have prepared two failing tests that illustrate the issue: https://github.com/gurdiga/ngmin/commit/c62e5b64b6c744f4ec075193b11e47e66efe69ad. I hope this clarifies it a bit. |
@gurdiga thanks! I'll take a look. |
+1 |
has bitten me |
…ngmin#89, btford/ngmin#87, btford/ngmin#85, btford/ngmin#78, btford/ngmin#77, btford/ngmin#73, btford/ngmin#70, btford/ngmin#64, btford/ngmin#63, btford/ngmin#61, btford/ngmin#59, btford/ngmin#57, btford/ngmin#56, btford/ngmin#54, btford/ngmin#50, btford/ngmin#46, btford/ngmin#43, btford/ngmin#42, btford/ngmin#37, btford/ngmin#35, btford/ngmin#22
Please try https://github.com/olov/ng-annotate. ngmin is now deprecated: #93 If your issue isn't resolved there please open an issue at https://github.com/olov/ng-annotate/issues If you really want ngmin to fix this issue, feel free to fork it and use that. |
Issue #21 fixed it in part. See there.
But this case still seems to fail (where the directive function is declared globally):
function myDirective($rootScope) {
return {
restrict: 'A',
controller: function($scope) {
this.scope = $scope;
}
}
}
angular.module('some-module').directive('some-directive', myDirective);
Addendum:
This also doesn't work (where the controller function within the directive is declared globally):
function myFunction($scope) {
this.scope = $scope;
}
angular.module('some-module').directive('some-directive', function myDirective($rootScope) {
return {
restrict: 'A',
controller: myFunction
}
});
The text was updated successfully, but these errors were encountered: