-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date label not in label JSON #4472
Comments
@bcazeaux Could you provide more context? Do you use a generated form or Camunda Form? How can we reproduce the issue (from the start, not from |
Thanks. Pending clarifications internally. I forwarded this issue. |
Hi @bcazeaux , thanks for reporting this The property I created an issue on the @nikku I believe we can close the issue on this repo |
@vsgoulart We'll leave the issue open and clearly link it to your upstream bug report. |
And for my record, why using "dateLabel" instead of "label" like every other component ? |
@bcazeaux It's just an implementation detail of the the datetime component. Under the hood it's always the same component if we render the time input or not so it always uses |
Describe the bug
Today, when adding a new DateTime input into a form, it is possible to set a Date Label. Meanwhile, the date label is stored in the json with a "dateLabel" key while a "label" key stays with the default value "datetime". This behavior apply only to DateTime input.
Should the label be directly stored in the label key ?
Steps to reproduce
{
"subtype": "date",
"dateLabel": "myCustomLabel",
"label": "Date time",
"type": "datetime",
"layout": {
"row": "Row_1d1o9f4",
"columns": null
}
Expected behavior
The JSON should look like :
{
"subtype": "date",
"label": "myCustomLabel",
"type": "datetime",
"layout": {
"row": "Row_1d1o9f4",
"columns": null
}
Environment
Additional context
No response
Depends on bpmn-io/form-js#1268
The text was updated successfully, but these errors were encountered: