Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Template Runtime Versions #4530

Closed
6 of 8 tasks
jarekdanielak opened this issue Sep 18, 2024 · 7 comments · Fixed by #4744
Closed
6 of 8 tasks

Element Template Runtime Versions #4530

jarekdanielak opened this issue Sep 18, 2024 · 7 comments · Fixed by #4744
Assignees
Labels
Milestone

Comments

@jarekdanielak
Copy link
Contributor

jarekdanielak commented Sep 18, 2024

This is a tracking issue for Element Template Runtime Versions epic.

Description

We want to detect, communicate and help users solve incompatibilities between their platform version and element template version.

We want to warn the user about the incompatibility in a non-blocking way, allowing them to fix the problem or continue with the deployment.

To do:

Follow up:

Note:

  • Make sure the solution covers applying a template through both properties panel and element context menu.
  • Supported platform versions JSON field should be optional.
  • Current template upgrade feature should not offer an upgrade to an incompatible version.

Additional documentation

@jarekdanielak jarekdanielak added needs discussion Needs further discussion enhancement New feature or request element templates labels Sep 18, 2024
@jarekdanielak jarekdanielak self-assigned this Sep 18, 2024
@jarekdanielak jarekdanielak added the backlog Queued in backlog label Sep 18, 2024 — with bpmn-io-tasks
@nikku
Copy link
Member

nikku commented Sep 18, 2024

Detect and act upon incompatibilities:

I'd add "User is offered templates relevant to his context".

@lmbateman
Copy link

Yana has done some work on missing templates that might be informative. I'll go through it and see if there's anything we need to be aware of.

@jarekdanielak jarekdanielak added the ready Ready to be worked on label Oct 27, 2024 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the backlog Queued in backlog label Oct 27, 2024
@nikku
Copy link
Member

nikku commented Nov 26, 2024

@jarekdanielak Let's ensure we keep this issue (our tracking issue) updated and relevant during the course of the implementation. 🙂

@jarekdanielak jarekdanielak added the in progress Currently worked on label Dec 3, 2024 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the ready Ready to be worked on label Dec 3, 2024
@jarekdanielak
Copy link
Contributor Author

Updated after latest discussions.

nikku added a commit to bpmn-io/element-templates-validator that referenced this issue Dec 6, 2024
jarekdanielak added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Dec 6, 2024
Config for current runtime platform and version can now be passed to elementTemplates. If template has information about supported engines, compatibility will be verified.

Related to camunda/camunda-modeler#4530
@jarekdanielak
Copy link
Contributor Author

Decision tree of choosing the latest compatible version of element template along with some edge use-cases.

excali-el-templates

@jarekdanielak jarekdanielak removed the needs discussion Needs further discussion label Dec 6, 2024
nikku added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Dec 9, 2024
Config for current runtime platform and version can now be passed to elementTemplates. If template has information about supported engines, compatibility will be verified.

Related to camunda/camunda-modeler#4530
nikku added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Dec 9, 2024
Config for current runtime platform and version can now be passed to elementTemplates. If template has information about supported engines, compatibility will be verified.

Related to camunda/camunda-modeler#4530
jarekdanielak pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Dec 11, 2024
Config for current runtime platform and version can now be passed to elementTemplates. If template has information about supported engines, compatibility will be verified.

Related to camunda/camunda-modeler#4530

feat(element-templates): emit <changed> as part of <set>

  This allows us to safely use <set> to reflect internal changes.
nikku added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Dec 12, 2024
  Config for current runtime platform and version can now be passed to elementTemplates. If template has information about supported engines, compatibility will be verified.

  Related to camunda/camunda-modeler#4530

feat: emit <changed> as part of <set>

  This allows us to safely use <set> to reflect internal changes.
jarekdanielak pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Dec 12, 2024
  Config for current runtime platform and version can now be passed to elementTemplates. If template has information about supported engines, compatibility will be verified.

  Related to camunda/camunda-modeler#4530

feat: emit <changed> as part of <set>

  This allows us to safely use <set> to reflect internal changes.
@barmac barmac added this to the M84 milestone Dec 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
nikku pushed a commit that referenced this issue Dec 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 13, 2024
@jarekdanielak
Copy link
Contributor Author

Reopening as there are still some integration and documentation tasks to do.

@jarekdanielak jarekdanielak reopened this Dec 16, 2024
@jarekdanielak jarekdanielak added the in progress Currently worked on label Dec 16, 2024
@jarekdanielak
Copy link
Contributor Author

With the feature integrated in both modelers and documentation pending to be merged, I consider this closed now.

@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants