-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with constructTransaction endpoint for a wallet created from xpub #4872
Comments
There are reports from Daedalus users experiencing the same problem with wallets restored from mnemonic. In this case, the problem seems to affect only some of the wallets. Our team was not able to reproduce it. |
@szymonmaslowski I can see this issue is referenced from a closed issue on your side, and there's been a Daedalus release, is this still relevant? Also, the description of the issue's context is pretty terse, can you elaborate on the conditions under which you observed the behaviour to be incorrect? Is this only for HW wallets? If I just restore a wallet from public key but the secret key is software, do you observe the same problem? What's the state of the wallet? How are the ADA's delegated? It would help to have a minimal example reproducing the issue. |
I have tried point 2. above on a wallet restored from public account key. Here is the state of the wallet:
The transaction I submit is:
and got the following output:
so indeed the OP's output is confirmed. The question is: Is this is a bug or a feature? |
This PR probably will fix that error (too early we check policy key is there, we might either and also be ok) #4850 |
@paweljakubas we tried out the changes from the PR you mentioned and unfortunately, it doesn't help. |
@abailly We are doing a nasty workaround so it would be much appreciated to resolve the problem. |
@szymonmaslowski I can confirm this is a bug and @paweljakubas 's PR does not fix it. |
<!-- Detail in a few bullet points the work accomplished in this PR. Before you submit, don't forget to: * Make sure the GitHub PR fields are correct: ✓ Set a good Title for your PR. ✓ Assign yourself to the PR. ✓ Assign one or more reviewer(s). ✓ Link to a Jira issue, and/or other GitHub issues or PRs. ✓ In the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. * Don't waste reviewers' time: ✓ If it's a draft, select the Create Draft PR option. ✓ Self-review your changes to make sure nothing unexpected slipped through. * Try to make your intent clear: ✓ Write a good Description that explains what this PR is meant to do. ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding Jira ticket. ✓ Highlight what Testing you have done. ✓ Acknowledge any changes required to the Documentation. --> `policyXPub` is needed in constructTransaction in two cases: - tx contains minting/burning action - tx deals with reference scripting and has reference script template nonempty instead of using `policyXPub` we use `policyXPubM` throught the function and only deconstruct it when checking those two cases. `ErrReadPolicyPublicKeyAbsen` is used for the those two valid situations when policy xpub is missing. ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number Fix #4872 <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. -->
Just checking...
cardano-wallet
bug.cardano-wallet
release.cardano-node
version for that release ofcardano-wallet
.Version
v2024-11-18
Platform
macOS 14
Installation method
Nix
Network configuration
preview
Context
In the Daedalus, we serve HWs by restoring them in the Cardano Wallet using their
account_public_key
. Those wallets are having an issue calling theconstructTransaction
endpoint.Description
Steps to Reproduce
account_public_key
{ vote: 'abstain' }
payloadExpected behavior
TX with votes delegation is correctly constructed
Actual behavior
Receiving an
missing_policy_public_key
error in responseThe text was updated successfully, but these errors were encountered: